Files
ApiCore/ApiCore-Backend/test/colonies.e2e-spec.ts
T
Nick SzaunigandClaude Sonnet 5 139ea6fdd7 feat: RBAC Rollen & Rechte (Phase 1 - Datenmodell, Roles-Verwaltung, Guard-Infrastruktur)
Replaces the fixed 5-value Role enum with a database-driven Role/Permission
model: admins can create custom roles with a precise per-resource/action
permission set (83-key code-owned catalog), instead of being locked to
ADMIN/BEEKEEPER/STAFF/READONLY/API_CLIENT.

- New Role/Permission/RolePermission tables; legacy Role enum renamed to
  LegacyRole and kept as User.legacyRole so all existing @Roles() call
  sites keep working unchanged during the migration.
- New RolesController/RolesService (CRUD, permission-set editing,
  deactivate/reactivate) with lockout-prevention invariants: system roles
  (ADMIN) can't be edited or deactivated, and a role still assigned to
  users can't be deactivated.
- New PermissionResolverService (30s-cached, DB-fresh per user) and
  PermissionsGuard + @RequirePermission(), registered as an additional
  APP_GUARD alongside the legacy RolesGuard so both systems run
  side-by-side until controllers are migrated in Phase 2.
- PermissionCatalogSyncService seeds any new catalog entries into the DB
  on boot, so future features only touch the TS catalog.
- New GET /auth/me returns the caller's role and effective permissions.
- Migration hand-written (destructive column rename) with grants derived
  from a fresh grep of every existing @Roles() call site, verified
  against 5 controllers read in full for STAFF's exact write boundary.
- test/roles.e2e-spec.ts covers the new endpoints and invariants end to
  end; test/authorization-coverage.e2e-spec.ts added but skipped until
  Phase 2 gives every controller a @RequirePermission.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-08-26 06:52:24 +02:00

219 lines
7.1 KiB
TypeScript

import { INestApplication } from '@nestjs/common';
import * as bcrypt from 'bcryptjs';
import request from 'supertest';
import { App } from 'supertest/types';
import { PrismaService } from '../src/prisma/prisma.service';
import { createTestApp } from './utils/create-test-app';
import { login } from './utils/api';
interface ColonyBody {
id: string;
code: string;
apiaryId: string;
status: string;
}
interface ColonyHistoryBody {
apiaryHistory: unknown[];
queenHistory: unknown[];
lineageAsSource: unknown[];
lineageAsResult: unknown[];
}
describe('Colonies (e2e)', () => {
let app: INestApplication<App>;
let prisma: PrismaService;
const beekeeperEmail = `colonies-e2e-beekeeper-${Date.now()}@example.com`;
const staffEmail = `colonies-e2e-staff-${Date.now()}@example.com`;
const password = 'SuperSecret123!';
let beekeeperId: string;
let staffId: string;
let beekeeperToken: string;
let staffToken: string;
let apiaryAId: string;
let apiaryBId: string;
let colonyId: string;
let childColonyId: string;
let colonyToMergeId: string;
beforeAll(async () => {
app = await createTestApp();
prisma = app.get(PrismaService);
const passwordHash = await bcrypt.hash(password, 12);
const beekeeper = await prisma.user.create({
data: {
email: beekeeperEmail,
passwordHash,
name: 'Beekeeper',
legacyRole: 'BEEKEEPER',
role: { connect: { key: 'BEEKEEPER' } },
},
});
beekeeperId = beekeeper.id;
const staff = await prisma.user.create({
data: {
email: staffEmail,
passwordHash,
name: 'Staff',
legacyRole: 'STAFF',
role: { connect: { key: 'STAFF' } },
},
});
staffId = staff.id;
beekeeperToken = (await login(app, beekeeperEmail, password)).accessToken;
staffToken = (await login(app, staffEmail, password)).accessToken;
const apiaryA = await prisma.apiary.create({
data: { name: `Stand A ${Date.now()}` },
});
apiaryAId = apiaryA.id;
const apiaryB = await prisma.apiary.create({
data: { name: `Stand B ${Date.now()}` },
});
apiaryBId = apiaryB.id;
});
afterAll(async () => {
await prisma.colonyLineage.deleteMany({
where: { OR: [{ fromColonyId: colonyId }, { toColonyId: colonyId }] },
});
await prisma.colonyApiaryHistory.deleteMany({ where: { colonyId } });
await prisma.colony.deleteMany({
where: {
id: { in: [colonyId, childColonyId, colonyToMergeId].filter(Boolean) },
},
});
await prisma.apiary.deleteMany({
where: { id: { in: [apiaryAId, apiaryBId] } },
});
await prisma.refreshToken.deleteMany({
where: { userId: { in: [beekeeperId, staffId] } },
});
await prisma.auditLog.deleteMany({
where: { userId: { in: [beekeeperId, staffId] } },
});
await prisma.user.deleteMany({
where: { id: { in: [beekeeperId, staffId] } },
});
await app.close();
});
it('rejects colony creation for STAFF', () => {
return request(app.getHttpServer())
.post('/api/v1/colonies')
.set('Authorization', `Bearer ${staffToken}`)
.send({
code: `V-${Date.now()}`,
apiaryId: apiaryAId,
colonyType: 'PRODUCTION_COLONY',
})
.expect(403);
});
it('lets a BEEKEEPER create a colony', async () => {
const response = await request(app.getHttpServer())
.post('/api/v1/colonies')
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({
code: `V-${Date.now()}`,
apiaryId: apiaryAId,
colonyType: 'PRODUCTION_COLONY',
})
.expect(201);
const created = response.body as ColonyBody;
expect(created.apiaryId).toBe(apiaryAId);
colonyId = created.id;
});
it('moves the colony to another apiary and records history', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/colonies/${colonyId}/move`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ apiaryId: apiaryBId, notes: 'Umzug' })
.expect(201);
expect((response.body as ColonyBody).apiaryId).toBe(apiaryBId);
const history = await request(app.getHttpServer())
.get(`/api/v1/colonies/${colonyId}/history`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.expect(200);
expect((history.body as ColonyHistoryBody).apiaryHistory).toHaveLength(1);
});
it('splits the colony into a new nucleus colony', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/colonies/${colonyId}/split`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ code: `V-${Date.now()}-A`, colonyType: 'NUCLEUS_COLONY' })
.expect(201);
const child = response.body as ColonyBody;
expect(child.apiaryId).toBe(apiaryBId);
childColonyId = child.id;
const history = await request(app.getHttpServer())
.get(`/api/v1/colonies/${colonyId}/history`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.expect(200);
expect((history.body as ColonyHistoryBody).lineageAsSource).toHaveLength(1);
});
it('merges another colony into the surviving one', async () => {
const otherColony = await request(app.getHttpServer())
.post('/api/v1/colonies')
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({
code: `V-${Date.now()}-M`,
apiaryId: apiaryBId,
colonyType: 'PRODUCTION_COLONY',
})
.expect(201);
colonyToMergeId = (otherColony.body as ColonyBody).id;
await request(app.getHttpServer())
.post(`/api/v1/colonies/${colonyId}/merge`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ mergedColonyIds: [colonyToMergeId] })
.expect(201);
const merged = await request(app.getHttpServer())
.get(`/api/v1/colonies/${colonyToMergeId}`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.expect(200);
expect((merged.body as ColonyBody).status).toBe('MERGED');
});
it('dissolves the colony without deleting it', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/colonies/${colonyId}/dissolve`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.expect(201);
expect((response.body as ColonyBody).status).toBe('DISSOLVED');
await request(app.getHttpServer())
.get(`/api/v1/colonies/${colonyId}`)
.set('Authorization', `Bearer ${staffToken}`)
.expect(200);
await request(app.getHttpServer())
.post(`/api/v1/colonies/${colonyId}/move`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ apiaryId: apiaryAId })
.expect(409);
});
it('reactivates a dissolved colony, and rejects reactivating an already-active one', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/colonies/${colonyId}/reactivate`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.expect(201);
expect((response.body as ColonyBody).status).toBe('ACTIVE');
await request(app.getHttpServer())
.post(`/api/v1/colonies/${colonyId}/reactivate`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.expect(409);
});
});