Files
ApiCore/ApiCore-Backend/test/honey-batches.e2e-spec.ts
T
Nick SzaunigandClaude Sonnet 5 139ea6fdd7 feat: RBAC Rollen & Rechte (Phase 1 - Datenmodell, Roles-Verwaltung, Guard-Infrastruktur)
Replaces the fixed 5-value Role enum with a database-driven Role/Permission
model: admins can create custom roles with a precise per-resource/action
permission set (83-key code-owned catalog), instead of being locked to
ADMIN/BEEKEEPER/STAFF/READONLY/API_CLIENT.

- New Role/Permission/RolePermission tables; legacy Role enum renamed to
  LegacyRole and kept as User.legacyRole so all existing @Roles() call
  sites keep working unchanged during the migration.
- New RolesController/RolesService (CRUD, permission-set editing,
  deactivate/reactivate) with lockout-prevention invariants: system roles
  (ADMIN) can't be edited or deactivated, and a role still assigned to
  users can't be deactivated.
- New PermissionResolverService (30s-cached, DB-fresh per user) and
  PermissionsGuard + @RequirePermission(), registered as an additional
  APP_GUARD alongside the legacy RolesGuard so both systems run
  side-by-side until controllers are migrated in Phase 2.
- PermissionCatalogSyncService seeds any new catalog entries into the DB
  on boot, so future features only touch the TS catalog.
- New GET /auth/me returns the caller's role and effective permissions.
- Migration hand-written (destructive column rename) with grants derived
  from a fresh grep of every existing @Roles() call site, verified
  against 5 controllers read in full for STAFF's exact write boundary.
- test/roles.e2e-spec.ts covers the new endpoints and invariants end to
  end; test/authorization-coverage.e2e-spec.ts added but skipped until
  Phase 2 gives every controller a @RequirePermission.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-08-26 06:52:24 +02:00

213 lines
7.5 KiB
TypeScript

import { INestApplication } from '@nestjs/common';
import * as bcrypt from 'bcryptjs';
import request from 'supertest';
import { App } from 'supertest/types';
import { PrismaService } from '../src/prisma/prisma.service';
import { createTestApp } from './utils/create-test-app';
import { login } from './utils/api';
interface HoneyBatchBody {
id: string;
batchNumber: string;
measurements: { id: string }[];
storageContainerId: string | null;
}
interface RelocationBody {
id: string;
fromStorageContainerId: string | null;
toStorageContainerId: string;
}
interface TraceabilityBody {
honeyBatch: { batchNumber: string };
extraction: { id: string };
harvests: { colonies: { code: string }[] }[];
}
describe('Honey batches (e2e)', () => {
let app: INestApplication<App>;
let prisma: PrismaService;
const beekeeperEmail = `honey-batches-e2e-beekeeper-${Date.now()}@example.com`;
const staffEmail = `honey-batches-e2e-staff-${Date.now()}@example.com`;
const password = 'SuperSecret123!';
let beekeeperId: string;
let staffId: string;
let beekeeperToken: string;
let staffToken: string;
let apiaryId: string;
let colonyId: string;
let harvestId: string;
let extractionId: string;
let honeyBatchId: string;
let containerAId: string;
let containerBId: string;
beforeAll(async () => {
app = await createTestApp();
prisma = app.get(PrismaService);
const passwordHash = await bcrypt.hash(password, 12);
const beekeeper = await prisma.user.create({
data: {
email: beekeeperEmail,
passwordHash,
name: 'Beekeeper',
legacyRole: 'BEEKEEPER',
role: { connect: { key: 'BEEKEEPER' } },
},
});
beekeeperId = beekeeper.id;
const staff = await prisma.user.create({
data: {
email: staffEmail,
passwordHash,
name: 'Staff',
legacyRole: 'STAFF',
role: { connect: { key: 'STAFF' } },
},
});
staffId = staff.id;
beekeeperToken = (await login(app, beekeeperEmail, password)).accessToken;
staffToken = (await login(app, staffEmail, password)).accessToken;
const apiary = await prisma.apiary.create({
data: { name: `Stand ${Date.now()}` },
});
apiaryId = apiary.id;
const colony = await prisma.colony.create({
data: {
code: `V-${Date.now()}`,
apiaryId,
colonyType: 'PRODUCTION_COLONY',
},
});
colonyId = colony.id;
const harvest = await prisma.harvest.create({
data: { apiaryId, date: new Date(), userId: beekeeperId },
});
harvestId = harvest.id;
await prisma.harvestColony.create({ data: { harvestId, colonyId } });
const extraction = await prisma.extraction.create({
data: { date: new Date(), userId: beekeeperId },
});
extractionId = extraction.id;
await prisma.extractionHarvest.create({
data: { extractionId, harvestId },
});
const containerA = await prisma.storageContainer.create({
data: { code: `LB-A-${Date.now()}` },
});
containerAId = containerA.id;
const containerB = await prisma.storageContainer.create({
data: { code: `LB-B-${Date.now()}` },
});
containerBId = containerB.id;
});
afterAll(async () => {
if (honeyBatchId) {
await prisma.honeyBatchRelocation.deleteMany({
where: { honeyBatchId },
});
await prisma.honeyMeasurement.deleteMany({ where: { honeyBatchId } });
await prisma.honeyBatch.deleteMany({ where: { id: honeyBatchId } });
}
await prisma.storageContainer.deleteMany({
where: { id: { in: [containerAId, containerBId] } },
});
await prisma.extractionHarvest.deleteMany({ where: { extractionId } });
await prisma.extraction.deleteMany({ where: { id: extractionId } });
await prisma.harvestColony.deleteMany({ where: { harvestId } });
await prisma.harvest.deleteMany({ where: { id: harvestId } });
await prisma.colony.deleteMany({ where: { id: colonyId } });
await prisma.apiary.deleteMany({ where: { id: apiaryId } });
await prisma.refreshToken.deleteMany({
where: { userId: { in: [beekeeperId, staffId] } },
});
await prisma.auditLog.deleteMany({
where: { userId: { in: [beekeeperId, staffId] } },
});
await prisma.user.deleteMany({
where: { id: { in: [beekeeperId, staffId] } },
});
await app.close();
});
it('rejects create for a STAFF user', () => {
return request(app.getHttpServer())
.post('/api/v1/honey-batches')
.set('Authorization', `Bearer ${staffToken}`)
.send({ batchNumber: `HC-${Date.now()}`, extractionId })
.expect(403);
});
it('lets a BEEKEEPER user create a honey batch from an extraction', async () => {
const response = await request(app.getHttpServer())
.post('/api/v1/honey-batches')
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ batchNumber: `HC-${Date.now()}`, extractionId, amount: 20 })
.expect(201);
const honeyBatch = response.body as HoneyBatchBody;
honeyBatchId = honeyBatch.id;
expect(honeyBatch.batchNumber).toEqual(expect.stringContaining('HC-'));
});
it('adds a water content measurement to the batch', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/honey-batches/${honeyBatchId}/measurements`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ waterContent: 17.4, measuredAt: new Date().toISOString() })
.expect(201);
const honeyBatch = response.body as HoneyBatchBody;
expect(honeyBatch.measurements).toHaveLength(1);
});
it('traces the honey batch back to its source colonies', async () => {
const response = await request(app.getHttpServer())
.get(`/api/v1/honey-batches/${honeyBatchId}/traceability`)
.set('Authorization', `Bearer ${staffToken}`)
.expect(200);
const trace = response.body as TraceabilityBody;
expect(trace.extraction.id).toBe(extractionId);
expect(trace.harvests[0]?.colonies[0]?.code).toBeDefined();
});
it('relocates the honey batch into a storage container', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/honey-batches/${honeyBatchId}/relocate`)
.set('Authorization', `Bearer ${staffToken}`)
.send({ storageContainerId: containerAId, notes: 'Erstbefüllung' })
.expect(201);
const honeyBatch = response.body as HoneyBatchBody;
expect(honeyBatch.storageContainerId).toBe(containerAId);
});
it('rejects relocation to a nonexistent storage container', () => {
return request(app.getHttpServer())
.post(`/api/v1/honey-batches/${honeyBatchId}/relocate`)
.set('Authorization', `Bearer ${staffToken}`)
.send({ storageContainerId: 'does-not-exist' })
.expect(404);
});
it('relocates the honey batch again and records both moves in history', async () => {
await request(app.getHttpServer())
.post(`/api/v1/honey-batches/${honeyBatchId}/relocate`)
.set('Authorization', `Bearer ${staffToken}`)
.send({ storageContainerId: containerBId })
.expect(201);
const response = await request(app.getHttpServer())
.get(`/api/v1/honey-batches/${honeyBatchId}/relocations`)
.set('Authorization', `Bearer ${staffToken}`)
.expect(200);
const relocations = response.body as RelocationBody[];
expect(relocations).toHaveLength(2);
expect(relocations[0].toStorageContainerId).toBe(containerBId);
expect(relocations[0].fromStorageContainerId).toBe(containerAId);
expect(relocations[1].toStorageContainerId).toBe(containerAId);
expect(relocations[1].fromStorageContainerId).toBeNull();
});
});