Files
ApiCore/ApiCore-Backend/test/honey-batches.e2e-spec.ts
T
Nick SzaunigandClaude Opus 5.5 10cbe9bf2d
Backend Image / build-and-push (push) Successful in 3m15s
Frontend Image / build-and-push (push) Successful in 6m2s
fix: Paket 0 – data integrity, security hardening and field usability
Backend
- Backup covers every Prisma model (bundle v3); a guard test fails for any
  new model that is neither backed up nor explicitly excluded. Unsealed
  bundles may only add rows to 27 legacy master/field tables and never
  overwrite; counters, ledgers, settings, roles etc. need a sealed file.
  Shared import limit BACKUP_MAX_IMPORT_BYTES (default 50 MB, max 256 MB)
  with warnings in log and UI; replaced document files are removed after
  commit.
- Post-commit side effects (automation, calendar sync, webhooks) run via
  runAfterCommit and never turn a committed write into a 500, so retries
  with the same Idempotency-Key no longer create duplicates.
- Calendar outbox is multi-replica safe: per-entry claims with stale
  takeover, revision-based settle, new Graph event only on 404/410,
  transactionId on create, 30 s Graph timeout, URL-encoded ids, GUID
  validation for groupId, "run now" in background and resets FAILED.
- Automation tasks are deduplicated under a row lock on the rule.
- Update DTOs follow one null rule: omitted = unchanged, null clears a
  nullable field, null on a required field is a 400.
- Varroa mites/day is recomputed on correction; withdrawal status is
  checked against the harvest date (?at=), bounded colonyIds; inspection
  create is audited; updates re-enqueue calendar entries.
- Dashboard, statistics and apiary/colony guards treat WEAK, CONSPICUOUS
  and QUEENLESS colonies as living.
- Prisma errors and body-parser errors are logged without query values or
  request bodies.
- Migration 20261012100000_calendar_sync_claims; schema index name aligned
  with the existing database object.

Frontend
- Sticky save bar sticks again (no scroll container ancestors, card uses
  overflow-clip), safe-area insets, scroll-padding, FAB hidden on forms,
  sticky desktop sidebar.
- Inspections record yes / no / not checked instead of silent defaults.
- All living colonies are selectable; shared RecordSelect, EnumSelect,
  ChoiceGroup and TriStateField replace per-page copies; selects show
  names instead of ids; labels point at real controls.
- Emptied optional fields are sent as null (emptyToNull) so every field
  can be cleared; dates default to the local day and are sent via
  toApiDate.
- Harvest withdrawal warning uses the harvest date; backup page warns when
  a backup outgrows the import limit and lists skipped tables.

Build and docs
- Docker builds fail unless lint, typecheck and unit tests pass.
- ARCHITECTURE.md updated (assumptions 9-12, 19-21, section 8) and spec
  docs/superpowers/specs/2026-10-12-plattform-rueckgrat-und-fahrplan-design.md
  for the backbone (api/worker/job roles, domain event outbox) and the
  feature roadmap T3-T7.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-12 16:38:55 +02:00

259 lines
9.1 KiB
TypeScript

import { INestApplication } from '@nestjs/common';
import * as bcrypt from 'bcryptjs';
import request from 'supertest';
import { App } from 'supertest/types';
import { PrismaService } from '../src/prisma/prisma.service';
import { createTestApp } from './utils/create-test-app';
import { login } from './utils/api';
interface HoneyBatchBody {
id: string;
batchNumber: string;
measurements: { id: string }[];
storageContainerId: string | null;
}
interface RelocationBody {
id: string;
fromStorageContainerId: string | null;
toStorageContainerId: string;
}
interface TraceabilityBody {
honeyBatch: { batchNumber: string };
extraction: { id: string };
harvests: { colonies: { code: string }[] }[];
}
describe('Honey batches (e2e)', () => {
let app: INestApplication<App>;
let prisma: PrismaService;
const beekeeperEmail = `honey-batches-e2e-beekeeper-${Date.now()}@example.com`;
const staffEmail = `honey-batches-e2e-staff-${Date.now()}@example.com`;
const adminEmail = `honey-batches-e2e-admin-${Date.now()}@example.com`;
const password = 'SuperSecret123!';
let beekeeperId: string;
let staffId: string;
let beekeeperToken: string;
let staffToken: string;
// Correcting a batch (PATCH) is an ADMIN permission.
let adminId: string;
let adminToken: string;
let apiaryId: string;
let colonyId: string;
let harvestId: string;
let extractionId: string;
let honeyBatchId: string;
let containerAId: string;
let containerBId: string;
beforeAll(async () => {
app = await createTestApp();
prisma = app.get(PrismaService);
const passwordHash = await bcrypt.hash(password, 12);
const beekeeper = await prisma.user.create({
data: {
email: beekeeperEmail,
passwordHash,
name: 'Beekeeper',
role: { connect: { key: 'BEEKEEPER' } },
},
});
beekeeperId = beekeeper.id;
const staff = await prisma.user.create({
data: {
email: staffEmail,
passwordHash,
name: 'Staff',
role: { connect: { key: 'STAFF' } },
},
});
staffId = staff.id;
const admin = await prisma.user.create({
data: {
email: adminEmail,
passwordHash,
name: 'Admin',
role: { connect: { key: 'ADMIN' } },
},
});
adminId = admin.id;
beekeeperToken = (await login(app, beekeeperEmail, password)).accessToken;
staffToken = (await login(app, staffEmail, password)).accessToken;
adminToken = (await login(app, adminEmail, password)).accessToken;
const apiary = await prisma.apiary.create({
data: { name: `Stand ${Date.now()}` },
});
apiaryId = apiary.id;
const colony = await prisma.colony.create({
data: {
code: `V-${Date.now()}`,
apiaryId,
colonyType: 'PRODUCTION_COLONY',
},
});
colonyId = colony.id;
const harvest = await prisma.harvest.create({
data: { apiaryId, date: new Date(), userId: beekeeperId },
});
harvestId = harvest.id;
await prisma.harvestColony.create({ data: { harvestId, colonyId } });
const extraction = await prisma.extraction.create({
data: { date: new Date(), userId: beekeeperId },
});
extractionId = extraction.id;
await prisma.extractionHarvest.create({
data: { extractionId, harvestId },
});
const containerA = await prisma.storageContainer.create({
data: { code: `LB-A-${Date.now()}` },
});
containerAId = containerA.id;
const containerB = await prisma.storageContainer.create({
data: { code: `LB-B-${Date.now()}` },
});
containerBId = containerB.id;
});
afterAll(async () => {
if (honeyBatchId) {
await prisma.honeyBatchRelocation.deleteMany({
where: { honeyBatchId },
});
await prisma.honeyMeasurement.deleteMany({ where: { honeyBatchId } });
await prisma.honeyBatch.deleteMany({ where: { id: honeyBatchId } });
}
await prisma.storageContainer.deleteMany({
where: { id: { in: [containerAId, containerBId] } },
});
await prisma.extractionHarvest.deleteMany({ where: { extractionId } });
await prisma.extraction.deleteMany({ where: { id: extractionId } });
await prisma.harvestColony.deleteMany({ where: { harvestId } });
await prisma.harvest.deleteMany({ where: { id: harvestId } });
await prisma.colony.deleteMany({ where: { id: colonyId } });
await prisma.apiary.deleteMany({ where: { id: apiaryId } });
await prisma.refreshToken.deleteMany({
where: { userId: { in: [beekeeperId, staffId, adminId] } },
});
await prisma.auditLog.deleteMany({
where: { userId: { in: [beekeeperId, staffId, adminId] } },
});
await prisma.user.deleteMany({
where: { id: { in: [beekeeperId, staffId, adminId] } },
});
await app.close();
});
it('rejects create for a STAFF user', () => {
return request(app.getHttpServer())
.post('/api/v1/honey-batches')
.set('Authorization', `Bearer ${staffToken}`)
.send({ batchNumber: `HC-${Date.now()}`, extractionId })
.expect(403);
});
it('lets a BEEKEEPER user create a honey batch from an extraction', async () => {
const response = await request(app.getHttpServer())
.post('/api/v1/honey-batches')
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ batchNumber: `HC-${Date.now()}`, extractionId, amount: 20 })
.expect(201);
const honeyBatch = response.body as HoneyBatchBody;
honeyBatchId = honeyBatch.id;
expect(honeyBatch.batchNumber).toEqual(expect.stringContaining('HC-'));
});
it('adds a water content measurement to the batch', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/honey-batches/${honeyBatchId}/measurements`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ waterContent: 17.4, measuredAt: new Date().toISOString() })
.expect(201);
const honeyBatch = response.body as HoneyBatchBody;
expect(honeyBatch.measurements).toHaveLength(1);
});
it('traces the honey batch back to its source colonies', async () => {
const response = await request(app.getHttpServer())
.get(`/api/v1/honey-batches/${honeyBatchId}/traceability`)
.set('Authorization', `Bearer ${staffToken}`)
.expect(200);
const trace = response.body as TraceabilityBody;
expect(trace.extraction.id).toBe(extractionId);
expect(trace.harvests[0]?.colonies[0]?.code).toBeDefined();
});
it('relocates the honey batch into a storage container', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/honey-batches/${honeyBatchId}/relocate`)
.set('Authorization', `Bearer ${staffToken}`)
.send({ storageContainerId: containerAId, notes: 'Erstbefüllung' })
.expect(201);
const honeyBatch = response.body as HoneyBatchBody;
expect(honeyBatch.storageContainerId).toBe(containerAId);
});
it('rejects relocation to a nonexistent storage container', () => {
return request(app.getHttpServer())
.post(`/api/v1/honey-batches/${honeyBatchId}/relocate`)
.set('Authorization', `Bearer ${staffToken}`)
.send({ storageContainerId: 'does-not-exist' })
.expect(404);
});
it('relocates the honey batch again and records both moves in history', async () => {
await request(app.getHttpServer())
.post(`/api/v1/honey-batches/${honeyBatchId}/relocate`)
.set('Authorization', `Bearer ${staffToken}`)
.send({ storageContainerId: containerBId })
.expect(201);
const response = await request(app.getHttpServer())
.get(`/api/v1/honey-batches/${honeyBatchId}/relocations`)
.set('Authorization', `Bearer ${staffToken}`)
.expect(200);
const relocations = response.body as RelocationBody[];
expect(relocations).toHaveLength(2);
expect(relocations[0].toStorageContainerId).toBe(containerBId);
expect(relocations[0].fromStorageContainerId).toBe(containerAId);
expect(relocations[1].toStorageContainerId).toBe(containerAId);
expect(relocations[1].fromStorageContainerId).toBeNull();
});
it('removes the container on null without recording a relocation', async () => {
const response = await request(app.getHttpServer())
.patch(`/api/v1/honey-batches/${honeyBatchId}`)
.set('Authorization', `Bearer ${adminToken}`)
.send({ storageContainerId: null })
.expect(200);
expect((response.body as HoneyBatchBody).storageContainerId).toBeNull();
const relocations = await prisma.honeyBatchRelocation.count({
where: { honeyBatchId },
});
expect(relocations).toBe(2);
const auditEntry = await prisma.auditLog.findFirst({
where: {
entityType: 'HoneyBatch',
entityId: honeyBatchId,
action: 'UPDATE',
userId: adminId,
},
orderBy: { timestamp: 'desc' },
});
expect(auditEntry?.afterData).toEqual(
expect.objectContaining({ storageContainerId: null }),
);
});
it('rejects null for the required batch number', () => {
return request(app.getHttpServer())
.patch(`/api/v1/honey-batches/${honeyBatchId}`)
.set('Authorization', `Bearer ${adminToken}`)
.send({ batchNumber: null })
.expect(400);
});
});