Files
ApiCore/ApiCore-Backend/test/post-commit-side-effects.e2e-spec.ts
T
Nick SzaunigandClaude Opus 5.5 10cbe9bf2d
Backend Image / build-and-push (push) Successful in 3m15s
Frontend Image / build-and-push (push) Successful in 6m2s
fix: Paket 0 – data integrity, security hardening and field usability
Backend
- Backup covers every Prisma model (bundle v3); a guard test fails for any
  new model that is neither backed up nor explicitly excluded. Unsealed
  bundles may only add rows to 27 legacy master/field tables and never
  overwrite; counters, ledgers, settings, roles etc. need a sealed file.
  Shared import limit BACKUP_MAX_IMPORT_BYTES (default 50 MB, max 256 MB)
  with warnings in log and UI; replaced document files are removed after
  commit.
- Post-commit side effects (automation, calendar sync, webhooks) run via
  runAfterCommit and never turn a committed write into a 500, so retries
  with the same Idempotency-Key no longer create duplicates.
- Calendar outbox is multi-replica safe: per-entry claims with stale
  takeover, revision-based settle, new Graph event only on 404/410,
  transactionId on create, 30 s Graph timeout, URL-encoded ids, GUID
  validation for groupId, "run now" in background and resets FAILED.
- Automation tasks are deduplicated under a row lock on the rule.
- Update DTOs follow one null rule: omitted = unchanged, null clears a
  nullable field, null on a required field is a 400.
- Varroa mites/day is recomputed on correction; withdrawal status is
  checked against the harvest date (?at=), bounded colonyIds; inspection
  create is audited; updates re-enqueue calendar entries.
- Dashboard, statistics and apiary/colony guards treat WEAK, CONSPICUOUS
  and QUEENLESS colonies as living.
- Prisma errors and body-parser errors are logged without query values or
  request bodies.
- Migration 20261012100000_calendar_sync_claims; schema index name aligned
  with the existing database object.

Frontend
- Sticky save bar sticks again (no scroll container ancestors, card uses
  overflow-clip), safe-area insets, scroll-padding, FAB hidden on forms,
  sticky desktop sidebar.
- Inspections record yes / no / not checked instead of silent defaults.
- All living colonies are selectable; shared RecordSelect, EnumSelect,
  ChoiceGroup and TriStateField replace per-page copies; selects show
  names instead of ids; labels point at real controls.
- Emptied optional fields are sent as null (emptyToNull) so every field
  can be cleared; dates default to the local day and are sent via
  toApiDate.
- Harvest withdrawal warning uses the harvest date; backup page warns when
  a backup outgrows the import limit and lists skipped tables.

Build and docs
- Docker builds fail unless lint, typecheck and unit tests pass.
- ARCHITECTURE.md updated (assumptions 9-12, 19-21, section 8) and spec
  docs/superpowers/specs/2026-10-12-plattform-rueckgrat-und-fahrplan-design.md
  for the backbone (api/worker/job roles, domain event outbox) and the
  feature roadmap T3-T7.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-12 16:38:55 +02:00

219 lines
6.8 KiB
TypeScript

import { INestApplication } from '@nestjs/common';
import * as bcrypt from 'bcryptjs';
import request from 'supertest';
import { App } from 'supertest/types';
import { PrismaService } from '../src/prisma/prisma.service';
import { NotificationsService } from '../src/notifications/notifications.service';
import { CalendarSyncSettingsService } from '../src/calendar-sync/calendar-sync-settings.service';
import { AutomationService } from '../src/automation/automation.service';
import { createTestApp } from './utils/create-test-app';
import { login } from './utils/api';
/**
* Side effects that follow a committed write (automation rules, calendar
* sync, webhooks) must never turn that write into an error response: the
* offline queue would send the request again and store the record twice -
* for treatments that is a duplicate entry in the Bestandsbuch.
*/
describe('Post-commit side effects (e2e)', () => {
let app: INestApplication<App>;
let prisma: PrismaService;
const suffix = `${Date.now()}-${Math.round(Math.random() * 1e6)}`;
const email = `post-commit-e2e-${suffix}@example.com`;
const password = 'SuperSecret123!';
let token: string;
let apiaryId: string;
const server = () => app.getHttpServer();
const auth = () => ({ Authorization: `Bearer ${token}` });
async function createColony(code: string) {
return prisma.colony.create({
data: {
code: `${code}-${suffix}`,
apiaryId,
colonyType: 'PRODUCTION_COLONY',
},
});
}
beforeAll(async () => {
app = await createTestApp();
prisma = app.get(PrismaService);
await prisma.user.create({
data: {
email,
passwordHash: await bcrypt.hash(password, 12),
name: 'Post Commit',
role: { connect: { key: 'ADMIN' } },
},
});
token = (await login(app, email, password)).accessToken;
apiaryId = (
await prisma.apiary.create({ data: { name: `Post Commit ${suffix}` } })
).id;
});
afterEach(() => {
jest.restoreAllMocks();
});
afterAll(async () => {
await app.close();
});
describe('when a side effect fails', () => {
beforeEach(() => {
// Automation: the task is created, then the warning fails.
jest
.spyOn(app.get(NotificationsService), 'record')
.mockRejectedValue(new Error('notifications down'));
// Calendar sync: enqueue cannot read its settings.
jest
.spyOn(app.get(CalendarSyncSettingsService), 'get')
.mockRejectedValue(new Error('calendar settings down'));
// Webhooks: the subscriptions cannot be loaded.
jest
.spyOn(prisma.webhookSubscription, 'findMany')
.mockRejectedValue(new Error('webhook subscriptions down'));
});
it('still answers 201 for an inspection and replays it on a retry', async () => {
const colony = await createColony('PC-INSP');
const key = `post-commit-${suffix}-inspection`;
const body = {
colonyId: colony.id,
date: '2026-07-01T00:00:00.000Z',
queenSeen: false,
eggsPresent: false,
};
const first = await request(server())
.post('/api/v1/inspections')
.set(auth())
.set('Idempotency-Key', key)
.send(body)
.expect(201);
const retry = await request(server())
.post('/api/v1/inspections')
.set(auth())
.set('Idempotency-Key', key)
.send(body)
.expect(201);
expect((retry.body as { id: string }).id).toBe(
(first.body as { id: string }).id,
);
expect(
await prisma.inspection.count({ where: { colonyId: colony.id } }),
).toBe(1);
// The rule still did its main job before the warning failed.
expect(
await prisma.task.count({
where: {
relatedId: colony.id,
sourceAutomationTrigger: 'QUEENLESS_NO_EGGS',
},
}),
).toBe(1);
});
it('still answers 201 for a treatment when the rule evaluation fails', async () => {
jest
.spyOn(prisma.automationRule, 'upsert')
.mockRejectedValue(new Error('automation rules down'));
const colony = await createColony('PC-TREAT');
const key = `post-commit-${suffix}-treatment`;
const body = {
colonyId: colony.id,
date: '2026-08-01T00:00:00.000Z',
product: 'Oxalsäure',
};
const first = await request(server())
.post('/api/v1/treatments')
.set(auth())
.set('Idempotency-Key', key)
.send(body)
.expect(201);
const retry = await request(server())
.post('/api/v1/treatments')
.set(auth())
.set('Idempotency-Key', key)
.send(body)
.expect(201);
expect((retry.body as { id: string }).id).toBe(
(first.body as { id: string }).id,
);
expect(
await prisma.treatment.count({ where: { colonyId: colony.id } }),
).toBe(1);
});
});
describe('automation tasks', () => {
it('leaves one open task when several triggers for the same colony arrive at once', async () => {
const automation = app.get(AutomationService);
// The same object crossing the threshold on several pods/requests at
// once: every evaluation sees "no open task yet" unless checking and
// creating are serialised.
const item = await prisma.stockItem.create({
data: {
name: `Race ${suffix}`,
category: 'CONSUMABLE',
unit: 'Stück',
quantity: 1,
minThreshold: 5,
},
});
await Promise.all(
Array.from({ length: 8 }, () => automation.evaluateStockItem(item)),
);
expect(
await prisma.task.count({
where: {
relatedId: item.id,
sourceAutomationTrigger: 'STOCK_ITEM_LOW',
status: { in: ['OPEN', 'IN_PROGRESS'] },
},
}),
).toBe(1);
});
it('leaves one open task when several measurements for the same colony arrive at once', async () => {
const colony = await createColony('PC-RACE-HTTP');
const measurement = {
colonyId: colony.id,
date: '2026-08-15T00:00:00.000Z',
method: 'NATURAL_MITE_FALL',
miteCount: 20,
// One day on the board: 20 mites per day, above the default 10.
durationMinutes: 24 * 60,
};
await Promise.all(
Array.from({ length: 6 }, () =>
request(server())
.post('/api/v1/varroa-measurements')
.set(auth())
.send(measurement)
.expect(201),
),
);
expect(
await prisma.task.count({
where: {
relatedId: colony.id,
sourceAutomationTrigger: 'VARROA_THRESHOLD',
status: { in: ['OPEN', 'IN_PROGRESS'] },
},
}),
).toBe(1);
});
});
});