Files
ApiCore/ApiCore-Backend/src/common/idempotency/idempotency-cleanup.service.spec.ts
T
Nick SzaunigandClaude Opus 5.5 10cbe9bf2d
Backend Image / build-and-push (push) Successful in 3m15s
Frontend Image / build-and-push (push) Successful in 6m2s
fix: Paket 0 – data integrity, security hardening and field usability
Backend
- Backup covers every Prisma model (bundle v3); a guard test fails for any
  new model that is neither backed up nor explicitly excluded. Unsealed
  bundles may only add rows to 27 legacy master/field tables and never
  overwrite; counters, ledgers, settings, roles etc. need a sealed file.
  Shared import limit BACKUP_MAX_IMPORT_BYTES (default 50 MB, max 256 MB)
  with warnings in log and UI; replaced document files are removed after
  commit.
- Post-commit side effects (automation, calendar sync, webhooks) run via
  runAfterCommit and never turn a committed write into a 500, so retries
  with the same Idempotency-Key no longer create duplicates.
- Calendar outbox is multi-replica safe: per-entry claims with stale
  takeover, revision-based settle, new Graph event only on 404/410,
  transactionId on create, 30 s Graph timeout, URL-encoded ids, GUID
  validation for groupId, "run now" in background and resets FAILED.
- Automation tasks are deduplicated under a row lock on the rule.
- Update DTOs follow one null rule: omitted = unchanged, null clears a
  nullable field, null on a required field is a 400.
- Varroa mites/day is recomputed on correction; withdrawal status is
  checked against the harvest date (?at=), bounded colonyIds; inspection
  create is audited; updates re-enqueue calendar entries.
- Dashboard, statistics and apiary/colony guards treat WEAK, CONSPICUOUS
  and QUEENLESS colonies as living.
- Prisma errors and body-parser errors are logged without query values or
  request bodies.
- Migration 20261012100000_calendar_sync_claims; schema index name aligned
  with the existing database object.

Frontend
- Sticky save bar sticks again (no scroll container ancestors, card uses
  overflow-clip), safe-area insets, scroll-padding, FAB hidden on forms,
  sticky desktop sidebar.
- Inspections record yes / no / not checked instead of silent defaults.
- All living colonies are selectable; shared RecordSelect, EnumSelect,
  ChoiceGroup and TriStateField replace per-page copies; selects show
  names instead of ids; labels point at real controls.
- Emptied optional fields are sent as null (emptyToNull) so every field
  can be cleared; dates default to the local day and are sent via
  toApiDate.
- Harvest withdrawal warning uses the harvest date; backup page warns when
  a backup outgrows the import limit and lists skipped tables.

Build and docs
- Docker builds fail unless lint, typecheck and unit tests pass.
- ARCHITECTURE.md updated (assumptions 9-12, 19-21, section 8) and spec
  docs/superpowers/specs/2026-10-12-plattform-rueckgrat-und-fahrplan-design.md
  for the backbone (api/worker/job roles, domain event outbox) and the
  feature roadmap T3-T7.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-12 16:38:55 +02:00

63 lines
2.2 KiB
TypeScript

import { Logger } from '@nestjs/common';
import { Prisma } from '../../../generated/prisma';
import { PrismaService } from '../../prisma/prisma.service';
import { IdempotencyCleanupService } from './idempotency-cleanup.service';
describe('IdempotencyCleanupService', () => {
let service: IdempotencyCleanupService;
let prisma: {
idempotencyRecord: { deleteMany: jest.Mock };
consumedToken: { deleteMany: jest.Mock };
};
beforeEach(() => {
prisma = {
idempotencyRecord: {
deleteMany: jest.fn().mockResolvedValue({ count: 0 }),
},
consumedToken: { deleteMany: jest.fn().mockResolvedValue({ count: 0 }) },
};
service = new IdempotencyCleanupService(prisma as unknown as PrismaService);
});
afterEach(() => {
jest.restoreAllMocks();
});
it('removes records older than the retention period and expired tokens', async () => {
prisma.idempotencyRecord.deleteMany.mockResolvedValue({ count: 3 });
const now = new Date('2026-10-12T04:00:00.000Z');
await expect(service.removeExpired(now)).resolves.toBe(3);
expect(prisma.idempotencyRecord.deleteMany).toHaveBeenCalledWith({
where: { createdAt: { lt: new Date('2026-07-14T04:00:00.000Z') } },
});
expect(prisma.consumedToken.deleteMany).toHaveBeenCalledWith({
where: { expiresAt: { lt: now } },
});
});
// The cron tick's own errors would otherwise reach the scheduler's logger
// with the full Prisma message and stack.
it('the daily tick never throws and logs a failure without the Prisma message', async () => {
const errorSpy = jest
.spyOn(Logger.prototype, 'error')
.mockImplementation(() => undefined);
prisma.idempotencyRecord.deleteMany.mockRejectedValue(
new Prisma.PrismaClientKnownRequestError('key "Max Mustermann"', {
code: 'P2024',
clientVersion: '7.9.1',
meta: { modelName: 'IdempotencyRecord' },
}),
);
await expect(service.scheduledCleanup()).resolves.toBeUndefined();
const [message, stack] = errorSpy.mock.calls[0] as [string, unknown];
expect(message).toContain('P2024');
expect(message).not.toContain('Mustermann');
expect(stack).toBeUndefined();
});
});