Letzte Phase des RBAC-Umbaus: die transitionale Rollen-Infrastruktur, die seit Phase 1 parallel zum neuen Role/Permission-System mitlief, ist jetzt komplett weg. - Prisma-Migration: User.legacyRole-Spalte und LegacyRole-Enum gedroppt (nichts liest die Spalte mehr, seit Phase 2 jeder Controller auf @RequirePermission laeuft). - roles.guard.ts, roles.guard.spec.ts, roles.decorator.ts geloescht; RolesGuard aus den APP_GUARD-Providern entfernt. - AuthenticatedUser/JWT-Payload verlieren das role-Feld (permissions werden ohnehin frisch pro Request aus der DB aufgeloest, nicht aus dem Claim). - Users-API: CreateUserDto/UpdateUserDto akzeptieren jetzt roleId (eine echte Role.id) statt der alten role-Enum-Werte; UsersService validiert, dass die Rolle existiert und aktiv ist, bevor sie zugewiesen wird. - Alle 34 e2e-Fixtures und der Seed-Script folgen dem neuen Schema. Verifiziert: tsc, lint, build, unit (220/220), volle e2e-Suite 159/159 gruen - keine uebersprungenen Tests. Co-Authored-By: Claude Sonnet 5 <[email protected]>
101 lines
3.0 KiB
TypeScript
101 lines
3.0 KiB
TypeScript
import { INestApplication } from '@nestjs/common';
|
|
import * as bcrypt from 'bcryptjs';
|
|
import request from 'supertest';
|
|
import { App } from 'supertest/types';
|
|
import { PrismaService } from '../src/prisma/prisma.service';
|
|
import { createTestApp } from './utils/create-test-app';
|
|
import { login } from './utils/api';
|
|
|
|
interface AuditLogEntryBody {
|
|
entityType: string;
|
|
entityId: string;
|
|
action: string;
|
|
}
|
|
|
|
describe('Audit log (e2e)', () => {
|
|
let app: INestApplication<App>;
|
|
let prisma: PrismaService;
|
|
const adminEmail = `audit-e2e-admin-${Date.now()}@example.com`;
|
|
const beekeeperEmail = `audit-e2e-beekeeper-${Date.now()}@example.com`;
|
|
const password = 'SuperSecret123!';
|
|
let adminId: string;
|
|
let beekeeperId: string;
|
|
let adminToken: string;
|
|
let beekeeperToken: string;
|
|
let apiaryId: string;
|
|
|
|
beforeAll(async () => {
|
|
app = await createTestApp();
|
|
prisma = app.get(PrismaService);
|
|
|
|
const passwordHash = await bcrypt.hash(password, 12);
|
|
const admin = await prisma.user.create({
|
|
data: {
|
|
email: adminEmail,
|
|
passwordHash,
|
|
name: 'Admin',
|
|
role: { connect: { key: 'ADMIN' } },
|
|
},
|
|
});
|
|
adminId = admin.id;
|
|
const beekeeper = await prisma.user.create({
|
|
data: {
|
|
email: beekeeperEmail,
|
|
passwordHash,
|
|
name: 'Beekeeper',
|
|
role: { connect: { key: 'BEEKEEPER' } },
|
|
},
|
|
});
|
|
beekeeperId = beekeeper.id;
|
|
adminToken = (await login(app, adminEmail, password)).accessToken;
|
|
beekeeperToken = (await login(app, beekeeperEmail, password)).accessToken;
|
|
});
|
|
|
|
afterAll(async () => {
|
|
if (apiaryId) {
|
|
await prisma.apiary.deleteMany({ where: { id: apiaryId } });
|
|
}
|
|
await prisma.auditLog.deleteMany({
|
|
where: { userId: { in: [adminId, beekeeperId] } },
|
|
});
|
|
await prisma.refreshToken.deleteMany({
|
|
where: { userId: { in: [adminId, beekeeperId] } },
|
|
});
|
|
await prisma.user.deleteMany({
|
|
where: { id: { in: [adminId, beekeeperId] } },
|
|
});
|
|
await app.close();
|
|
});
|
|
|
|
it('rejects the query for a non-admin user', () => {
|
|
return request(app.getHttpServer())
|
|
.get('/api/v1/audit-log')
|
|
.set('Authorization', `Bearer ${beekeeperToken}`)
|
|
.expect(403);
|
|
});
|
|
|
|
it('lets an ADMIN query the audit log for a created apiary', async () => {
|
|
const createResponse = await request(app.getHttpServer())
|
|
.post('/api/v1/apiaries')
|
|
.set('Authorization', `Bearer ${beekeeperToken}`)
|
|
.send({ name: `Stand ${Date.now()}` })
|
|
.expect(201);
|
|
const apiary = createResponse.body as { id: string };
|
|
apiaryId = apiary.id;
|
|
|
|
const response = await request(app.getHttpServer())
|
|
.get(`/api/v1/audit-log?entityType=Apiary&entityId=${apiaryId}`)
|
|
.set('Authorization', `Bearer ${adminToken}`)
|
|
.expect(200);
|
|
const entries = response.body as AuditLogEntryBody[];
|
|
expect(
|
|
entries.some(
|
|
(entry) =>
|
|
entry.entityType === 'Apiary' &&
|
|
entry.entityId === apiaryId &&
|
|
entry.action === 'CREATE',
|
|
),
|
|
).toBe(true);
|
|
});
|
|
});
|