Backend - Backup covers every Prisma model (bundle v3); a guard test fails for any new model that is neither backed up nor explicitly excluded. Unsealed bundles may only add rows to 27 legacy master/field tables and never overwrite; counters, ledgers, settings, roles etc. need a sealed file. Shared import limit BACKUP_MAX_IMPORT_BYTES (default 50 MB, max 256 MB) with warnings in log and UI; replaced document files are removed after commit. - Post-commit side effects (automation, calendar sync, webhooks) run via runAfterCommit and never turn a committed write into a 500, so retries with the same Idempotency-Key no longer create duplicates. - Calendar outbox is multi-replica safe: per-entry claims with stale takeover, revision-based settle, new Graph event only on 404/410, transactionId on create, 30 s Graph timeout, URL-encoded ids, GUID validation for groupId, "run now" in background and resets FAILED. - Automation tasks are deduplicated under a row lock on the rule. - Update DTOs follow one null rule: omitted = unchanged, null clears a nullable field, null on a required field is a 400. - Varroa mites/day is recomputed on correction; withdrawal status is checked against the harvest date (?at=), bounded colonyIds; inspection create is audited; updates re-enqueue calendar entries. - Dashboard, statistics and apiary/colony guards treat WEAK, CONSPICUOUS and QUEENLESS colonies as living. - Prisma errors and body-parser errors are logged without query values or request bodies. - Migration 20261012100000_calendar_sync_claims; schema index name aligned with the existing database object. Frontend - Sticky save bar sticks again (no scroll container ancestors, card uses overflow-clip), safe-area insets, scroll-padding, FAB hidden on forms, sticky desktop sidebar. - Inspections record yes / no / not checked instead of silent defaults. - All living colonies are selectable; shared RecordSelect, EnumSelect, ChoiceGroup and TriStateField replace per-page copies; selects show names instead of ids; labels point at real controls. - Emptied optional fields are sent as null (emptyToNull) so every field can be cleared; dates default to the local day and are sent via toApiDate. - Harvest withdrawal warning uses the harvest date; backup page warns when a backup outgrows the import limit and lists skipped tables. Build and docs - Docker builds fail unless lint, typecheck and unit tests pass. - ARCHITECTURE.md updated (assumptions 9-12, 19-21, section 8) and spec docs/superpowers/specs/2026-10-12-plattform-rueckgrat-und-fahrplan-design.md for the backbone (api/worker/job roles, domain event outbox) and the feature roadmap T3-T7. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
277 lines
8.7 KiB
TypeScript
277 lines
8.7 KiB
TypeScript
import { INestApplication } from '@nestjs/common';
|
|
import * as bcrypt from 'bcryptjs';
|
|
import request from 'supertest';
|
|
import { App } from 'supertest/types';
|
|
import { PrismaService } from '../src/prisma/prisma.service';
|
|
import { AutomationTriggerType, Prisma } from '../generated/prisma';
|
|
import { createTestApp } from './utils/create-test-app';
|
|
import { login } from './utils/api';
|
|
|
|
interface AutomationRuleBody {
|
|
id: string;
|
|
triggerType: string;
|
|
active: boolean;
|
|
config: Record<string, unknown> | null;
|
|
actionTemplate: string | null;
|
|
}
|
|
|
|
describe('Automation rules (e2e)', () => {
|
|
let app: INestApplication<App>;
|
|
let prisma: PrismaService;
|
|
const adminEmail = `automation-e2e-admin-${Date.now()}@example.com`;
|
|
const staffEmail = `automation-e2e-staff-${Date.now()}@example.com`;
|
|
const password = 'SuperSecret123!';
|
|
let adminId: string;
|
|
let staffId: string;
|
|
let adminToken: string;
|
|
let staffToken: string;
|
|
let apiaryId: string;
|
|
let colonyId: string;
|
|
let varroaRuleId: string;
|
|
|
|
beforeAll(async () => {
|
|
app = await createTestApp();
|
|
prisma = app.get(PrismaService);
|
|
|
|
const passwordHash = await bcrypt.hash(password, 12);
|
|
const admin = await prisma.user.create({
|
|
data: {
|
|
email: adminEmail,
|
|
passwordHash,
|
|
name: 'Automation E2E Admin',
|
|
role: { connect: { key: 'ADMIN' } },
|
|
},
|
|
});
|
|
adminId = admin.id;
|
|
const staff = await prisma.user.create({
|
|
data: {
|
|
email: staffEmail,
|
|
passwordHash,
|
|
name: 'Automation E2E Staff',
|
|
role: { connect: { key: 'STAFF' } },
|
|
},
|
|
});
|
|
staffId = staff.id;
|
|
adminToken = (await login(app, adminEmail, password)).accessToken;
|
|
staffToken = (await login(app, staffEmail, password)).accessToken;
|
|
|
|
const apiary = await prisma.apiary.create({
|
|
data: { name: `Automation Stand ${Date.now()}` },
|
|
});
|
|
apiaryId = apiary.id;
|
|
const colony = await prisma.colony.create({
|
|
data: {
|
|
code: `AUTO-${Date.now()}`,
|
|
apiaryId,
|
|
colonyType: 'PRODUCTION_COLONY',
|
|
},
|
|
});
|
|
colonyId = colony.id;
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await prisma.automationRule.updateMany({
|
|
where: { triggerType: 'VARROA_THRESHOLD' },
|
|
data: { active: true },
|
|
});
|
|
await prisma.task.deleteMany({ where: { relatedId: colonyId } });
|
|
await prisma.notification.deleteMany({ where: { relatedId: colonyId } });
|
|
await prisma.varroaMeasurement.deleteMany({ where: { colonyId } });
|
|
await prisma.inspection.deleteMany({ where: { colonyId } });
|
|
await prisma.colony.deleteMany({ where: { id: colonyId } });
|
|
await prisma.apiary.deleteMany({ where: { id: apiaryId } });
|
|
await prisma.refreshToken.deleteMany({
|
|
where: { userId: { in: [adminId, staffId] } },
|
|
});
|
|
await prisma.auditLog.deleteMany({
|
|
where: { userId: { in: [adminId, staffId] } },
|
|
});
|
|
await prisma.user.deleteMany({ where: { id: { in: [adminId, staffId] } } });
|
|
await app.close();
|
|
});
|
|
|
|
it('rejects a non-admin listing automation rules', () => {
|
|
return request(app.getHttpServer())
|
|
.get('/api/v1/automation-rules')
|
|
.set('Authorization', `Bearer ${staffToken}`)
|
|
.expect(403);
|
|
});
|
|
|
|
it('seeds every fixed trigger for an admin', async () => {
|
|
const response = await request(app.getHttpServer())
|
|
.get('/api/v1/automation-rules')
|
|
.set('Authorization', `Bearer ${adminToken}`)
|
|
.expect(200);
|
|
const rules = response.body as AutomationRuleBody[];
|
|
const triggerTypes = rules.map((rule) => rule.triggerType).sort();
|
|
expect(triggerTypes).toEqual(
|
|
[...Object.values(AutomationTriggerType)].sort(),
|
|
);
|
|
const varroaRule = rules.find(
|
|
(rule) => rule.triggerType === 'VARROA_THRESHOLD',
|
|
);
|
|
expect(varroaRule).toBeDefined();
|
|
varroaRuleId = varroaRule!.id;
|
|
});
|
|
|
|
it('creates a task and notification when queen not seen and no eggs present', async () => {
|
|
await request(app.getHttpServer())
|
|
.post('/api/v1/inspections')
|
|
.set('Authorization', `Bearer ${staffToken}`)
|
|
.send({
|
|
colonyId,
|
|
date: new Date().toISOString(),
|
|
queenSeen: false,
|
|
eggsPresent: false,
|
|
})
|
|
.expect(201);
|
|
|
|
const tasks = await prisma.task.findMany({
|
|
where: { relatedId: colonyId },
|
|
});
|
|
expect(tasks).toHaveLength(1);
|
|
expect(tasks[0].title).toContain('Kontrolle');
|
|
|
|
const notifications = await prisma.notification.findMany({
|
|
where: { relatedId: colonyId },
|
|
});
|
|
expect(notifications).toHaveLength(1);
|
|
});
|
|
|
|
it('does not trigger when the queen was seen', async () => {
|
|
await request(app.getHttpServer())
|
|
.post('/api/v1/inspections')
|
|
.set('Authorization', `Bearer ${staffToken}`)
|
|
.send({
|
|
colonyId,
|
|
date: new Date().toISOString(),
|
|
queenSeen: true,
|
|
eggsPresent: false,
|
|
})
|
|
.expect(201);
|
|
|
|
const tasks = await prisma.task.findMany({
|
|
where: { relatedId: colonyId },
|
|
});
|
|
expect(tasks).toHaveLength(1);
|
|
});
|
|
|
|
it('triggers a feeding task when feed status is kritisch', async () => {
|
|
await request(app.getHttpServer())
|
|
.post('/api/v1/inspections')
|
|
.set('Authorization', `Bearer ${staffToken}`)
|
|
.send({
|
|
colonyId,
|
|
date: new Date().toISOString(),
|
|
feedStatus: 'kritisch',
|
|
})
|
|
.expect(201);
|
|
|
|
const tasks = await prisma.task.findMany({
|
|
where: { relatedId: colonyId },
|
|
});
|
|
expect(tasks).toHaveLength(2);
|
|
expect(tasks.some((task) => task.title.includes('Fütterung'))).toBe(true);
|
|
});
|
|
|
|
it('triggers a treatment check when the varroa threshold is exceeded', async () => {
|
|
await request(app.getHttpServer())
|
|
.post('/api/v1/varroa-measurements')
|
|
.set('Authorization', `Bearer ${adminToken}`)
|
|
.send({
|
|
colonyId,
|
|
date: new Date().toISOString(),
|
|
method: 'NATURAL_MITE_FALL',
|
|
miteCount: 20,
|
|
// One day on the board: 20 mites per day, above the default 10.
|
|
durationMinutes: 24 * 60,
|
|
})
|
|
.expect(201);
|
|
|
|
const tasks = await prisma.task.findMany({
|
|
where: { relatedId: colonyId },
|
|
});
|
|
expect(tasks).toHaveLength(3);
|
|
expect(tasks.some((task) => task.title.includes('Behandlung'))).toBe(true);
|
|
});
|
|
|
|
it('does not compare a sample-based count against the per-day threshold', async () => {
|
|
const before = await prisma.task.count({ where: { relatedId: colonyId } });
|
|
await request(app.getHttpServer())
|
|
.post('/api/v1/varroa-measurements')
|
|
.set('Authorization', `Bearer ${adminToken}`)
|
|
.send({
|
|
colonyId,
|
|
date: new Date().toISOString(),
|
|
method: 'POWDERED_SUGAR',
|
|
miteCount: 50,
|
|
})
|
|
.expect(201);
|
|
expect(await prisma.task.count({ where: { relatedId: colonyId } })).toBe(
|
|
before,
|
|
);
|
|
});
|
|
|
|
it('lets an admin clear a rule config, which falls back to its defaults', async () => {
|
|
const before = await prisma.automationRule.findUniqueOrThrow({
|
|
where: { id: varroaRuleId },
|
|
});
|
|
try {
|
|
const response = await request(app.getHttpServer())
|
|
.patch(`/api/v1/automation-rules/${varroaRuleId}`)
|
|
.set('Authorization', `Bearer ${adminToken}`)
|
|
.send({ config: null })
|
|
.expect(200);
|
|
expect((response.body as { config: unknown }).config).toBeNull();
|
|
|
|
await request(app.getHttpServer())
|
|
.patch(`/api/v1/automation-rules/${varroaRuleId}`)
|
|
.set('Authorization', `Bearer ${adminToken}`)
|
|
.send({ active: null })
|
|
.expect(400);
|
|
} finally {
|
|
// The rule is shared by every suite - put its config back.
|
|
await prisma.automationRule.update({
|
|
where: { id: varroaRuleId },
|
|
data: {
|
|
config:
|
|
before.config === null
|
|
? Prisma.DbNull
|
|
: (before.config as Prisma.InputJsonValue),
|
|
},
|
|
});
|
|
}
|
|
});
|
|
|
|
it('lets an admin deactivate a rule, preventing further triggers', async () => {
|
|
await request(app.getHttpServer())
|
|
.patch(`/api/v1/automation-rules/${varroaRuleId}`)
|
|
.set('Authorization', `Bearer ${adminToken}`)
|
|
.send({ active: false })
|
|
.expect(200);
|
|
// Close the earlier tasks so the one-open-task-per-rule guard cannot be
|
|
// what keeps a new task from appearing - only the deactivation may.
|
|
await prisma.task.updateMany({
|
|
where: { relatedId: colonyId },
|
|
data: { status: 'DONE' },
|
|
});
|
|
|
|
await request(app.getHttpServer())
|
|
.post('/api/v1/varroa-measurements')
|
|
.set('Authorization', `Bearer ${adminToken}`)
|
|
.send({
|
|
colonyId,
|
|
date: new Date().toISOString(),
|
|
method: 'NATURAL_MITE_FALL',
|
|
miteCount: 30,
|
|
durationMinutes: 24 * 60,
|
|
})
|
|
.expect(201);
|
|
|
|
const tasks = await prisma.task.findMany({
|
|
where: { relatedId: colonyId },
|
|
});
|
|
expect(tasks).toHaveLength(3);
|
|
});
|
|
});
|