Files
ApiCore/ApiCore-Backend/test/tasks.e2e-spec.ts
T
Nick SzaunigandClaude Opus 5.5 10cbe9bf2d
Backend Image / build-and-push (push) Successful in 3m15s
Frontend Image / build-and-push (push) Successful in 6m2s
fix: Paket 0 – data integrity, security hardening and field usability
Backend
- Backup covers every Prisma model (bundle v3); a guard test fails for any
  new model that is neither backed up nor explicitly excluded. Unsealed
  bundles may only add rows to 27 legacy master/field tables and never
  overwrite; counters, ledgers, settings, roles etc. need a sealed file.
  Shared import limit BACKUP_MAX_IMPORT_BYTES (default 50 MB, max 256 MB)
  with warnings in log and UI; replaced document files are removed after
  commit.
- Post-commit side effects (automation, calendar sync, webhooks) run via
  runAfterCommit and never turn a committed write into a 500, so retries
  with the same Idempotency-Key no longer create duplicates.
- Calendar outbox is multi-replica safe: per-entry claims with stale
  takeover, revision-based settle, new Graph event only on 404/410,
  transactionId on create, 30 s Graph timeout, URL-encoded ids, GUID
  validation for groupId, "run now" in background and resets FAILED.
- Automation tasks are deduplicated under a row lock on the rule.
- Update DTOs follow one null rule: omitted = unchanged, null clears a
  nullable field, null on a required field is a 400.
- Varroa mites/day is recomputed on correction; withdrawal status is
  checked against the harvest date (?at=), bounded colonyIds; inspection
  create is audited; updates re-enqueue calendar entries.
- Dashboard, statistics and apiary/colony guards treat WEAK, CONSPICUOUS
  and QUEENLESS colonies as living.
- Prisma errors and body-parser errors are logged without query values or
  request bodies.
- Migration 20261012100000_calendar_sync_claims; schema index name aligned
  with the existing database object.

Frontend
- Sticky save bar sticks again (no scroll container ancestors, card uses
  overflow-clip), safe-area insets, scroll-padding, FAB hidden on forms,
  sticky desktop sidebar.
- Inspections record yes / no / not checked instead of silent defaults.
- All living colonies are selectable; shared RecordSelect, EnumSelect,
  ChoiceGroup and TriStateField replace per-page copies; selects show
  names instead of ids; labels point at real controls.
- Emptied optional fields are sent as null (emptyToNull) so every field
  can be cleared; dates default to the local day and are sent via
  toApiDate.
- Harvest withdrawal warning uses the harvest date; backup page warns when
  a backup outgrows the import limit and lists skipped tables.

Build and docs
- Docker builds fail unless lint, typecheck and unit tests pass.
- ARCHITECTURE.md updated (assumptions 9-12, 19-21, section 8) and spec
  docs/superpowers/specs/2026-10-12-plattform-rueckgrat-und-fahrplan-design.md
  for the backbone (api/worker/job roles, domain event outbox) and the
  feature roadmap T3-T7.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-12 16:38:55 +02:00

144 lines
4.4 KiB
TypeScript

import { INestApplication } from '@nestjs/common';
import * as bcrypt from 'bcryptjs';
import request from 'supertest';
import { App } from 'supertest/types';
import { PrismaService } from '../src/prisma/prisma.service';
import { createTestApp } from './utils/create-test-app';
import { login } from './utils/api';
interface TaskBody {
id: string;
status: string;
completedAt: string | null;
dueDate: string | null;
}
describe('Tasks (e2e)', () => {
let app: INestApplication<App>;
let prisma: PrismaService;
const staffEmail = `tasks-e2e-staff-${Date.now()}@example.com`;
const readonlyEmail = `tasks-e2e-readonly-${Date.now()}@example.com`;
const password = 'SuperSecret123!';
let staffId: string;
let readonlyId: string;
let staffToken: string;
let readonlyToken: string;
let taskId: string;
beforeAll(async () => {
app = await createTestApp();
prisma = app.get(PrismaService);
const passwordHash = await bcrypt.hash(password, 12);
const staff = await prisma.user.create({
data: {
email: staffEmail,
passwordHash,
name: 'Staff',
role: { connect: { key: 'STAFF' } },
},
});
staffId = staff.id;
const readonly = await prisma.user.create({
data: {
email: readonlyEmail,
passwordHash,
name: 'Readonly',
role: { connect: { key: 'READONLY' } },
},
});
readonlyId = readonly.id;
staffToken = (await login(app, staffEmail, password)).accessToken;
readonlyToken = (await login(app, readonlyEmail, password)).accessToken;
});
afterAll(async () => {
if (taskId) {
await prisma.task.delete({ where: { id: taskId } });
}
await prisma.refreshToken.deleteMany({
where: { userId: { in: [staffId, readonlyId] } },
});
await prisma.auditLog.deleteMany({
where: { userId: { in: [staffId, readonlyId] } },
});
await prisma.user.deleteMany({
where: { id: { in: [staffId, readonlyId] } },
});
await app.close();
});
it('rejects create for a READONLY user', () => {
return request(app.getHttpServer())
.post('/api/v1/tasks')
.set('Authorization', `Bearer ${readonlyToken}`)
.send({ title: 'Beute prüfen' })
.expect(403);
});
it('lets a STAFF user create a task', async () => {
const response = await request(app.getHttpServer())
.post('/api/v1/tasks')
.set('Authorization', `Bearer ${staffToken}`)
.send({ title: 'Beute prüfen', priority: 'HIGH' })
.expect(201);
const task = response.body as TaskBody;
taskId = task.id;
expect(task.status).toBe('OPEN');
});
it('lists tasks filtered by status', async () => {
const response = await request(app.getHttpServer())
.get('/api/v1/tasks?status=OPEN')
.set('Authorization', `Bearer ${readonlyToken}`)
.expect(200);
const tasks = response.body as TaskBody[];
expect(tasks.some((entry) => entry.id === taskId)).toBe(true);
});
it('clears the due date on null and audits the edit', async () => {
await request(app.getHttpServer())
.patch(`/api/v1/tasks/${taskId}`)
.set('Authorization', `Bearer ${staffToken}`)
.send({ dueDate: '2026-08-01T00:00:00.000Z' })
.expect(200);
const response = await request(app.getHttpServer())
.patch(`/api/v1/tasks/${taskId}`)
.set('Authorization', `Bearer ${staffToken}`)
.send({ dueDate: null })
.expect(200);
expect((response.body as TaskBody).dueDate).toBeNull();
const auditEntry = await prisma.auditLog.findFirst({
where: {
entityType: 'Task',
entityId: taskId,
action: 'UPDATE',
userId: staffId,
},
orderBy: { timestamp: 'desc' },
});
expect(auditEntry?.afterData).toEqual(
expect.objectContaining({ dueDate: null }),
);
});
it('rejects null for the required title', () => {
return request(app.getHttpServer())
.patch(`/api/v1/tasks/${taskId}`)
.set('Authorization', `Bearer ${staffToken}`)
.send({ title: null })
.expect(400);
});
it('completes a task', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/tasks/${taskId}/complete`)
.set('Authorization', `Bearer ${staffToken}`)
.expect(201);
const task = response.body as TaskBody;
expect(task.status).toBe('DONE');
expect(task.completedAt).not.toBeNull();
});
});