Files
ApiCore/ApiCore-Backend/test/task-templates.e2e-spec.ts
T
Nick SzaunigandClaude Opus 5.5 10cbe9bf2d
Backend Image / build-and-push (push) Successful in 3m15s
Frontend Image / build-and-push (push) Successful in 6m2s
fix: Paket 0 – data integrity, security hardening and field usability
Backend
- Backup covers every Prisma model (bundle v3); a guard test fails for any
  new model that is neither backed up nor explicitly excluded. Unsealed
  bundles may only add rows to 27 legacy master/field tables and never
  overwrite; counters, ledgers, settings, roles etc. need a sealed file.
  Shared import limit BACKUP_MAX_IMPORT_BYTES (default 50 MB, max 256 MB)
  with warnings in log and UI; replaced document files are removed after
  commit.
- Post-commit side effects (automation, calendar sync, webhooks) run via
  runAfterCommit and never turn a committed write into a 500, so retries
  with the same Idempotency-Key no longer create duplicates.
- Calendar outbox is multi-replica safe: per-entry claims with stale
  takeover, revision-based settle, new Graph event only on 404/410,
  transactionId on create, 30 s Graph timeout, URL-encoded ids, GUID
  validation for groupId, "run now" in background and resets FAILED.
- Automation tasks are deduplicated under a row lock on the rule.
- Update DTOs follow one null rule: omitted = unchanged, null clears a
  nullable field, null on a required field is a 400.
- Varroa mites/day is recomputed on correction; withdrawal status is
  checked against the harvest date (?at=), bounded colonyIds; inspection
  create is audited; updates re-enqueue calendar entries.
- Dashboard, statistics and apiary/colony guards treat WEAK, CONSPICUOUS
  and QUEENLESS colonies as living.
- Prisma errors and body-parser errors are logged without query values or
  request bodies.
- Migration 20261012100000_calendar_sync_claims; schema index name aligned
  with the existing database object.

Frontend
- Sticky save bar sticks again (no scroll container ancestors, card uses
  overflow-clip), safe-area insets, scroll-padding, FAB hidden on forms,
  sticky desktop sidebar.
- Inspections record yes / no / not checked instead of silent defaults.
- All living colonies are selectable; shared RecordSelect, EnumSelect,
  ChoiceGroup and TriStateField replace per-page copies; selects show
  names instead of ids; labels point at real controls.
- Emptied optional fields are sent as null (emptyToNull) so every field
  can be cleared; dates default to the local day and are sent via
  toApiDate.
- Harvest withdrawal warning uses the harvest date; backup page warns when
  a backup outgrows the import limit and lists skipped tables.

Build and docs
- Docker builds fail unless lint, typecheck and unit tests pass.
- ARCHITECTURE.md updated (assumptions 9-12, 19-21, section 8) and spec
  docs/superpowers/specs/2026-10-12-plattform-rueckgrat-und-fahrplan-design.md
  for the backbone (api/worker/job roles, domain event outbox) and the
  feature roadmap T3-T7.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-12 16:38:55 +02:00

146 lines
4.8 KiB
TypeScript

import { INestApplication } from '@nestjs/common';
import * as bcrypt from 'bcryptjs';
import request from 'supertest';
import { App } from 'supertest/types';
import { PrismaService } from '../src/prisma/prisma.service';
import { createTestApp } from './utils/create-test-app';
import { login } from './utils/api';
interface TaskTemplateBody {
id: string;
nextDueDate: string;
active: boolean;
recurrenceType: string;
recurrenceDayOfMonth: number | null;
intervalDays: number | null;
}
describe('TaskTemplates (e2e)', () => {
let app: INestApplication<App>;
let prisma: PrismaService;
const beekeeperEmail = `task-templates-e2e-beekeeper-${Date.now()}@example.com`;
const password = 'SuperSecret123!';
let beekeeperId: string;
let beekeeperToken: string;
let templateId: string;
beforeAll(async () => {
app = await createTestApp();
prisma = app.get(PrismaService);
const passwordHash = await bcrypt.hash(password, 12);
const beekeeper = await prisma.user.create({
data: {
email: beekeeperEmail,
passwordHash,
name: 'Beekeeper',
role: { connect: { key: 'BEEKEEPER' } },
},
});
beekeeperId = beekeeper.id;
beekeeperToken = (await login(app, beekeeperEmail, password)).accessToken;
});
afterAll(async () => {
if (templateId) {
await prisma.task.deleteMany({ where: { sourceTemplateId: templateId } });
await prisma.taskTemplate.delete({ where: { id: templateId } });
}
await prisma.refreshToken.deleteMany({ where: { userId: beekeeperId } });
await prisma.auditLog.deleteMany({ where: { userId: beekeeperId } });
await prisma.user.deleteMany({ where: { id: beekeeperId } });
await app.close();
});
it('rejects a YEARLY template missing recurrenceMonth/recurrenceDayOfMonth', () => {
return request(app.getHttpServer())
.post('/api/v1/task-templates')
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ title: 'Jahresinventur', recurrenceType: 'YEARLY' })
.expect(400);
});
it('creates an INTERVAL_DAYS template and computes nextDueDate', async () => {
const response = await request(app.getHttpServer())
.post('/api/v1/task-templates')
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({
title: `Fütterung ${Date.now()}`,
recurrenceType: 'INTERVAL_DAYS',
intervalDays: 1,
})
.expect(201);
const body = response.body as TaskTemplateBody;
templateId = body.id;
expect(body.nextDueDate).toEqual(expect.any(String));
});
it('generates a due Task lazily on GET /tasks and advances nextDueDate', async () => {
const yesterday = new Date();
yesterday.setUTCDate(yesterday.getUTCDate() - 1);
await prisma.taskTemplate.update({
where: { id: templateId },
data: { nextDueDate: yesterday },
});
await request(app.getHttpServer())
.get('/api/v1/tasks')
.set('Authorization', `Bearer ${beekeeperToken}`)
.expect(200);
const generatedTask = await prisma.task.findFirst({
where: { sourceTemplateId: templateId },
});
expect(generatedTask).not.toBeNull();
const template = await prisma.taskTemplate.findUniqueOrThrow({
where: { id: templateId },
});
expect(template.nextDueDate.getTime()).toBeGreaterThan(yesterday.getTime());
});
it('rejects a recurrence emptied of a field it needs', () => {
return request(app.getHttpServer())
.patch(`/api/v1/task-templates/${templateId}`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({ recurrenceType: 'MONTHLY', recurrenceDayOfMonth: null })
.expect(400);
});
it('clears the interval when switching to a monthly recurrence', async () => {
const response = await request(app.getHttpServer())
.patch(`/api/v1/task-templates/${templateId}`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.send({
recurrenceType: 'MONTHLY',
recurrenceDayOfMonth: 5,
intervalDays: null,
})
.expect(200);
const body = response.body as TaskTemplateBody;
expect(body.recurrenceType).toBe('MONTHLY');
expect(body.recurrenceDayOfMonth).toBe(5);
expect(body.intervalDays).toBeNull();
const auditEntry = await prisma.auditLog.findFirst({
where: {
entityType: 'TaskTemplate',
entityId: templateId,
action: 'UPDATE',
userId: beekeeperId,
},
orderBy: { timestamp: 'desc' },
});
expect(auditEntry?.afterData).toEqual(
expect.objectContaining({ intervalDays: null }),
);
});
it('deactivates a template', async () => {
const response = await request(app.getHttpServer())
.post(`/api/v1/task-templates/${templateId}/deactivate`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.expect(201);
expect((response.body as TaskTemplateBody).active).toBe(false);
});
});