Backend - Backup covers every Prisma model (bundle v3); a guard test fails for any new model that is neither backed up nor explicitly excluded. Unsealed bundles may only add rows to 27 legacy master/field tables and never overwrite; counters, ledgers, settings, roles etc. need a sealed file. Shared import limit BACKUP_MAX_IMPORT_BYTES (default 50 MB, max 256 MB) with warnings in log and UI; replaced document files are removed after commit. - Post-commit side effects (automation, calendar sync, webhooks) run via runAfterCommit and never turn a committed write into a 500, so retries with the same Idempotency-Key no longer create duplicates. - Calendar outbox is multi-replica safe: per-entry claims with stale takeover, revision-based settle, new Graph event only on 404/410, transactionId on create, 30 s Graph timeout, URL-encoded ids, GUID validation for groupId, "run now" in background and resets FAILED. - Automation tasks are deduplicated under a row lock on the rule. - Update DTOs follow one null rule: omitted = unchanged, null clears a nullable field, null on a required field is a 400. - Varroa mites/day is recomputed on correction; withdrawal status is checked against the harvest date (?at=), bounded colonyIds; inspection create is audited; updates re-enqueue calendar entries. - Dashboard, statistics and apiary/colony guards treat WEAK, CONSPICUOUS and QUEENLESS colonies as living. - Prisma errors and body-parser errors are logged without query values or request bodies. - Migration 20261012100000_calendar_sync_claims; schema index name aligned with the existing database object. Frontend - Sticky save bar sticks again (no scroll container ancestors, card uses overflow-clip), safe-area insets, scroll-padding, FAB hidden on forms, sticky desktop sidebar. - Inspections record yes / no / not checked instead of silent defaults. - All living colonies are selectable; shared RecordSelect, EnumSelect, ChoiceGroup and TriStateField replace per-page copies; selects show names instead of ids; labels point at real controls. - Emptied optional fields are sent as null (emptyToNull) so every field can be cleared; dates default to the local day and are sent via toApiDate. - Harvest withdrawal warning uses the harvest date; backup page warns when a backup outgrows the import limit and lists skipped tables. Build and docs - Docker builds fail unless lint, typecheck and unit tests pass. - ARCHITECTURE.md updated (assumptions 9-12, 19-21, section 8) and spec docs/superpowers/specs/2026-10-12-plattform-rueckgrat-und-fahrplan-design.md for the backbone (api/worker/job roles, domain event outbox) and the feature roadmap T3-T7. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
154 lines
4.6 KiB
TypeScript
154 lines
4.6 KiB
TypeScript
import { NotFoundException } from '@nestjs/common';
|
|
import { InspectionsService } from './inspections.service';
|
|
import { PrismaService } from '../prisma/prisma.service';
|
|
import { WebhooksService } from '../webhooks/webhooks.service';
|
|
import { AutomationService } from '../automation/automation.service';
|
|
import { AuditLogService } from '../audit/audit-log.service';
|
|
import { CalendarSyncService } from '../calendar-sync/calendar-sync.service';
|
|
|
|
describe('InspectionsService', () => {
|
|
let service: InspectionsService;
|
|
let prisma: {
|
|
inspection: {
|
|
findMany: jest.Mock;
|
|
findUnique: jest.Mock;
|
|
create: jest.Mock;
|
|
update: jest.Mock;
|
|
};
|
|
task: { create: jest.Mock };
|
|
};
|
|
let auditLog: { record: jest.Mock };
|
|
let calendarSync: { enqueue: jest.Mock; cancel: jest.Mock };
|
|
|
|
const inspection = {
|
|
id: 'inspection-1',
|
|
colonyId: 'colony-1',
|
|
date: new Date(),
|
|
};
|
|
|
|
beforeEach(() => {
|
|
prisma = {
|
|
inspection: {
|
|
findMany: jest.fn(),
|
|
findUnique: jest.fn(),
|
|
create: jest.fn(),
|
|
update: jest.fn(),
|
|
},
|
|
task: { create: jest.fn() },
|
|
};
|
|
const webhooks = { dispatch: jest.fn().mockResolvedValue(undefined) };
|
|
const automation = {
|
|
evaluateInspection: jest.fn().mockResolvedValue(undefined),
|
|
};
|
|
auditLog = { record: jest.fn().mockResolvedValue(undefined) };
|
|
calendarSync = { enqueue: jest.fn(), cancel: jest.fn() };
|
|
service = new InspectionsService(
|
|
prisma as unknown as PrismaService,
|
|
webhooks as unknown as WebhooksService,
|
|
automation as unknown as AutomationService,
|
|
auditLog as unknown as AuditLogService,
|
|
calendarSync as unknown as CalendarSyncService,
|
|
);
|
|
});
|
|
|
|
it('findById throws NotFoundException when missing', async () => {
|
|
prisma.inspection.findUnique.mockResolvedValue(null);
|
|
await expect(service.findById('missing')).rejects.toBeInstanceOf(
|
|
NotFoundException,
|
|
);
|
|
});
|
|
|
|
it('create stores the acting user as the inspector', async () => {
|
|
prisma.inspection.create.mockResolvedValue(inspection);
|
|
|
|
await service.create(
|
|
{ colonyId: 'colony-1', date: '2026-01-01' },
|
|
'user-1',
|
|
);
|
|
|
|
const [[createArg]] = prisma.inspection.create.mock.calls as [
|
|
[{ data: { colonyId: string; userId: string } }],
|
|
];
|
|
expect(createArg.data.colonyId).toBe('colony-1');
|
|
expect(createArg.data.userId).toBe('user-1');
|
|
});
|
|
|
|
it('create writes an audit log entry with the created inspection', async () => {
|
|
prisma.inspection.create.mockResolvedValue(inspection);
|
|
|
|
await service.create(
|
|
{ colonyId: 'colony-1', date: '2026-01-01' },
|
|
'user-1',
|
|
);
|
|
|
|
expect(auditLog.record).toHaveBeenCalledWith({
|
|
entityType: 'Inspection',
|
|
entityId: 'inspection-1',
|
|
action: 'CREATE',
|
|
userId: 'user-1',
|
|
afterData: inspection,
|
|
});
|
|
});
|
|
|
|
it('update writes an audit log entry with before and after data', async () => {
|
|
prisma.inspection.findUnique.mockResolvedValue(inspection);
|
|
const updated = { ...inspection, notes: 'geändert' };
|
|
prisma.inspection.update.mockResolvedValue(updated);
|
|
|
|
const result = await service.update(
|
|
'inspection-1',
|
|
{ notes: 'geändert' },
|
|
'user-1',
|
|
);
|
|
|
|
expect(result).toBe(updated);
|
|
expect(auditLog.record).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
entityType: 'Inspection',
|
|
entityId: 'inspection-1',
|
|
action: 'UPDATE',
|
|
beforeData: inspection,
|
|
afterData: updated,
|
|
}),
|
|
);
|
|
});
|
|
|
|
it('update re-enqueues the calendar sync so a changed date moves the event', async () => {
|
|
prisma.inspection.findUnique.mockResolvedValue(inspection);
|
|
prisma.inspection.update.mockResolvedValue(inspection);
|
|
|
|
await service.update('inspection-1', { date: '2026-05-02' }, 'user-1');
|
|
|
|
expect(calendarSync.enqueue).toHaveBeenCalledWith(
|
|
'INSPECTION',
|
|
'inspection-1',
|
|
);
|
|
});
|
|
|
|
it('createTaskFromInspection links the task to the inspection and its colony', async () => {
|
|
prisma.inspection.findUnique.mockResolvedValue(inspection);
|
|
prisma.task.create.mockResolvedValue({ id: 'task-1' });
|
|
|
|
await service.createTaskFromInspection(
|
|
'inspection-1',
|
|
{ title: 'Nachschauen' },
|
|
'user-1',
|
|
);
|
|
|
|
const [[taskArg]] = prisma.task.create.mock.calls as [
|
|
[
|
|
{
|
|
data: {
|
|
sourceInspectionId: string;
|
|
relatedType: string;
|
|
relatedId: string;
|
|
};
|
|
},
|
|
],
|
|
];
|
|
expect(taskArg.data.sourceInspectionId).toBe('inspection-1');
|
|
expect(taskArg.data.relatedType).toBe('COLONY');
|
|
expect(taskArg.data.relatedId).toBe('colony-1');
|
|
});
|
|
});
|