Files
ApiCore/ApiCore-Backend/src/backup/backup.controller.ts
T
Nick SzaunigandClaude Opus 5.5 10cbe9bf2d
Backend Image / build-and-push (push) Successful in 3m15s
Frontend Image / build-and-push (push) Successful in 6m2s
fix: Paket 0 – data integrity, security hardening and field usability
Backend
- Backup covers every Prisma model (bundle v3); a guard test fails for any
  new model that is neither backed up nor explicitly excluded. Unsealed
  bundles may only add rows to 27 legacy master/field tables and never
  overwrite; counters, ledgers, settings, roles etc. need a sealed file.
  Shared import limit BACKUP_MAX_IMPORT_BYTES (default 50 MB, max 256 MB)
  with warnings in log and UI; replaced document files are removed after
  commit.
- Post-commit side effects (automation, calendar sync, webhooks) run via
  runAfterCommit and never turn a committed write into a 500, so retries
  with the same Idempotency-Key no longer create duplicates.
- Calendar outbox is multi-replica safe: per-entry claims with stale
  takeover, revision-based settle, new Graph event only on 404/410,
  transactionId on create, 30 s Graph timeout, URL-encoded ids, GUID
  validation for groupId, "run now" in background and resets FAILED.
- Automation tasks are deduplicated under a row lock on the rule.
- Update DTOs follow one null rule: omitted = unchanged, null clears a
  nullable field, null on a required field is a 400.
- Varroa mites/day is recomputed on correction; withdrawal status is
  checked against the harvest date (?at=), bounded colonyIds; inspection
  create is audited; updates re-enqueue calendar entries.
- Dashboard, statistics and apiary/colony guards treat WEAK, CONSPICUOUS
  and QUEENLESS colonies as living.
- Prisma errors and body-parser errors are logged without query values or
  request bodies.
- Migration 20261012100000_calendar_sync_claims; schema index name aligned
  with the existing database object.

Frontend
- Sticky save bar sticks again (no scroll container ancestors, card uses
  overflow-clip), safe-area insets, scroll-padding, FAB hidden on forms,
  sticky desktop sidebar.
- Inspections record yes / no / not checked instead of silent defaults.
- All living colonies are selectable; shared RecordSelect, EnumSelect,
  ChoiceGroup and TriStateField replace per-page copies; selects show
  names instead of ids; labels point at real controls.
- Emptied optional fields are sent as null (emptyToNull) so every field
  can be cleared; dates default to the local day and are sent via
  toApiDate.
- Harvest withdrawal warning uses the harvest date; backup page warns when
  a backup outgrows the import limit and lists skipped tables.

Build and docs
- Docker builds fail unless lint, typecheck and unit tests pass.
- ARCHITECTURE.md updated (assumptions 9-12, 19-21, section 8) and spec
  docs/superpowers/specs/2026-10-12-plattform-rueckgrat-und-fahrplan-design.md
  for the backbone (api/worker/job roles, domain event outbox) and the
  feature roadmap T3-T7.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-12 16:38:55 +02:00

138 lines
4.7 KiB
TypeScript

import {
BadRequestException,
Body,
Controller,
Get,
Logger,
Patch,
Post,
Res,
UploadedFile,
UseInterceptors,
} from '@nestjs/common';
import { FileInterceptor } from '@nestjs/platform-express';
import { ApiBearerAuth, ApiConsumes, ApiTags } from '@nestjs/swagger';
import type { Response } from 'express';
import { RequirePermission } from '../auth/decorators/require-permission.decorator';
import { CurrentUser } from '../auth/decorators/current-user.decorator';
import type { AuthenticatedUser } from '../auth/types/authenticated-user';
import { BackupSettings } from '../../generated/prisma';
import { BackupService } from './backup.service';
import { ReauthService } from '../auth/reauth/reauth.service';
import { BackupImportProofDto } from './dto/backup-import-proof.dto';
import {
BackupScheduleStatus,
BackupSchedulerService,
} from './backup-scheduler.service';
import { BackupSettingsService } from './backup-settings.service';
import { UpdateBackupSettingsDto } from './dto/update-backup-settings.dto';
import {
backupMaxImportBytes,
exceedsBackupImportLimit,
formatMegabytes,
} from './backup-import-limit';
@ApiTags('backup')
@ApiBearerAuth()
@Controller('backup')
export class BackupController {
private readonly logger = new Logger(BackupController.name);
constructor(
private readonly backupService: BackupService,
private readonly backupSchedulerService: BackupSchedulerService,
private readonly backupSettingsService: BackupSettingsService,
private readonly reauth: ReauthService,
) {}
@RequirePermission('backup:export')
@Get('schedule')
getSchedule(): Promise<BackupScheduleStatus> {
return this.backupSchedulerService.getStatus();
}
@RequirePermission('backup:export')
@Post('schedule/run-now')
runScheduleNow(): Promise<{ fileName: string }> {
return this.backupSchedulerService.runNow();
}
@RequirePermission('backup:configure')
@Get('settings')
getSettings(): Promise<BackupSettings> {
return this.backupSettingsService.get();
}
@RequirePermission('backup:configure')
@Patch('settings')
async updateSettings(
@Body() dto: UpdateBackupSettingsDto,
@CurrentUser() actor: AuthenticatedUser,
): Promise<BackupSettings> {
const settings = await this.backupSettingsService.update(dto, actor.id);
await this.backupSchedulerService.reload();
return settings;
}
@RequirePermission('backup:export')
@Get('export')
async export(@Res() res: Response): Promise<void> {
const sealed = await this.backupService.exportSealed();
const body = JSON.stringify(sealed);
const sizeBytes = Buffer.byteLength(body);
if (exceedsBackupImportLimit(sizeBytes)) {
// Still delivered: losing the data is worse than needing a raised
// BACKUP_MAX_IMPORT_BYTES to restore it. The UI compares the file
// against the limit from GET /backup/schedule and warns there.
this.logger.warn(
`Exportiertes Backup ist ${formatMegabytes(sizeBytes)} groß und überschreitet das Import-Limit von ${formatMegabytes(backupMaxImportBytes())} - eine Wiederherstellung würde scheitern`,
);
}
const filename = `apicore-backup-${new Date().toISOString().slice(0, 10)}.json`;
res.setHeader('Content-Type', 'application/json; charset=utf-8');
res.setHeader('Content-Disposition', `attachment; filename="${filename}"`);
res.setHeader('Cache-Control', 'no-store');
res.send(body);
}
@RequirePermission('backup:import')
@Post('import')
@ApiConsumes('multipart/form-data')
@UseInterceptors(
// Size limit from MulterModule in BackupModule (BACKUP_MAX_IMPORT_BYTES).
FileInterceptor('file', {
fileFilter: (_req, file, callback) => {
if (!file.originalname.toLowerCase().endsWith('.json')) {
callback(
new BadRequestException('Nur JSON-Dateien werden unterstützt'),
false,
);
return;
}
callback(null, true);
},
}),
)
async import(
@UploadedFile() file: Express.Multer.File | undefined,
@Body() proof: BackupImportProofDto,
@CurrentUser() actor: AuthenticatedUser,
) {
// Restoring overwrites every account: prove it is really you, now.
await this.reauth.verify(actor.id, proof);
if (!file) {
throw new BadRequestException('No file uploaded');
}
let parsed: unknown;
try {
parsed = JSON.parse(file.buffer.toString('utf-8'));
} catch {
throw new BadRequestException('Datei ist kein gültiges JSON');
}
const summary = await this.backupService.importFile(parsed, actor.id);
// The backup may have restored the schedule's settings too.
await this.backupSchedulerService.reload();
return summary;
}
}