Replaces the fixed 5-value Role enum with a database-driven Role/Permission model: admins can create custom roles with a precise per-resource/action permission set (83-key code-owned catalog), instead of being locked to ADMIN/BEEKEEPER/STAFF/READONLY/API_CLIENT. - New Role/Permission/RolePermission tables; legacy Role enum renamed to LegacyRole and kept as User.legacyRole so all existing @Roles() call sites keep working unchanged during the migration. - New RolesController/RolesService (CRUD, permission-set editing, deactivate/reactivate) with lockout-prevention invariants: system roles (ADMIN) can't be edited or deactivated, and a role still assigned to users can't be deactivated. - New PermissionResolverService (30s-cached, DB-fresh per user) and PermissionsGuard + @RequirePermission(), registered as an additional APP_GUARD alongside the legacy RolesGuard so both systems run side-by-side until controllers are migrated in Phase 2. - PermissionCatalogSyncService seeds any new catalog entries into the DB on boot, so future features only touch the TS catalog. - New GET /auth/me returns the caller's role and effective permissions. - Migration hand-written (destructive column rename) with grants derived from a fresh grep of every existing @Roles() call site, verified against 5 controllers read in full for STAFF's exact write boundary. - test/roles.e2e-spec.ts covers the new endpoints and invariants end to end; test/authorization-coverage.e2e-spec.ts added but skipped until Phase 2 gives every controller a @RequirePermission. Co-Authored-By: Claude Sonnet 5 <[email protected]>
107 lines
3.3 KiB
TypeScript
107 lines
3.3 KiB
TypeScript
import { INestApplication } from '@nestjs/common';
|
|
import * as bcrypt from 'bcryptjs';
|
|
import request from 'supertest';
|
|
import { App } from 'supertest/types';
|
|
import { PrismaService } from '../src/prisma/prisma.service';
|
|
import { createTestApp } from './utils/create-test-app';
|
|
import { AccessTokenBody, extractCookie, login } from './utils/api';
|
|
|
|
describe('Auth (e2e)', () => {
|
|
let app: INestApplication<App>;
|
|
let prisma: PrismaService;
|
|
const email = `auth-e2e-${Date.now()}@example.com`;
|
|
const password = 'SuperSecret123!';
|
|
let userId: string;
|
|
|
|
beforeAll(async () => {
|
|
app = await createTestApp();
|
|
prisma = app.get(PrismaService);
|
|
|
|
const passwordHash = await bcrypt.hash(password, 12);
|
|
const user = await prisma.user.create({
|
|
data: {
|
|
email,
|
|
passwordHash,
|
|
name: 'Auth E2E User',
|
|
legacyRole: 'ADMIN',
|
|
role: { connect: { key: 'ADMIN' } },
|
|
},
|
|
});
|
|
userId = user.id;
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await prisma.refreshToken.deleteMany({ where: { userId } });
|
|
await prisma.auditLog.deleteMany({ where: { userId } });
|
|
await prisma.user.delete({ where: { id: userId } });
|
|
await app.close();
|
|
});
|
|
|
|
it('rejects login with wrong password', () => {
|
|
return request(app.getHttpServer())
|
|
.post('/api/v1/auth/login')
|
|
.send({ email, password: 'wrong-password' })
|
|
.expect(401);
|
|
});
|
|
|
|
it('logs in, returns an access token, and sets an httpOnly refresh-token cookie', async () => {
|
|
const tokens = await login(app, email, password);
|
|
|
|
expect(tokens.accessToken).toEqual(expect.any(String));
|
|
expect(tokens.refreshTokenCookie).toMatch(/^refreshToken=/);
|
|
});
|
|
|
|
it('rejects a protected route without a token', () => {
|
|
return request(app.getHttpServer()).get('/api/v1/users').expect(401);
|
|
});
|
|
|
|
it('accepts a protected route with a valid access token', async () => {
|
|
const tokens = await login(app, email, password);
|
|
|
|
await request(app.getHttpServer())
|
|
.get('/api/v1/users')
|
|
.set('Authorization', `Bearer ${tokens.accessToken}`)
|
|
.expect(200);
|
|
});
|
|
|
|
it('rejects refresh when no refresh-token cookie is present', () => {
|
|
return request(app.getHttpServer())
|
|
.post('/api/v1/auth/refresh')
|
|
.expect(401);
|
|
});
|
|
|
|
it('rotates the refresh-token cookie and rejects reuse of the old one', async () => {
|
|
const tokens = await login(app, email, password);
|
|
|
|
const refreshResponse = await request(app.getHttpServer())
|
|
.post('/api/v1/auth/refresh')
|
|
.set('Cookie', tokens.refreshTokenCookie)
|
|
.expect(200);
|
|
const rotatedCookie = extractCookie(refreshResponse, 'refreshToken');
|
|
|
|
expect(rotatedCookie).not.toEqual(tokens.refreshTokenCookie);
|
|
expect((refreshResponse.body as AccessTokenBody).accessToken).toEqual(
|
|
expect.any(String),
|
|
);
|
|
|
|
await request(app.getHttpServer())
|
|
.post('/api/v1/auth/refresh')
|
|
.set('Cookie', tokens.refreshTokenCookie)
|
|
.expect(401);
|
|
});
|
|
|
|
it('logs out and invalidates the refresh-token cookie', async () => {
|
|
const tokens = await login(app, email, password);
|
|
|
|
await request(app.getHttpServer())
|
|
.post('/api/v1/auth/logout')
|
|
.set('Cookie', tokens.refreshTokenCookie)
|
|
.expect(204);
|
|
|
|
await request(app.getHttpServer())
|
|
.post('/api/v1/auth/refresh')
|
|
.set('Cookie', tokens.refreshTokenCookie)
|
|
.expect(401);
|
|
});
|
|
});
|