Files
ApiCore/ApiCore-Backend/test/documents.e2e-spec.ts
Nick SzaunigandClaude Opus 5.5 5d11756a87 fix: keep quantities, colony/queen states and tasks consistent under retries
Data-integrity fixes found in a systematic review of ApiCore:

- Bottling booked the honey batch amount from a value read outside the
  transaction and wrote an absolute result back, so two concurrent
  bottlings (double tap, two devices) could both pass the check and one
  deduction was lost. Bookings now use a conditional UPDATE inside the
  transaction; corrections and deletions give amounts back atomically.
- Outgoing stock movements could drive stock below zero; the removal is
  now a conditional decrement that refuses when stock is insufficient.
- Weak, conspicuous and queenless colonies were treated as "not active"
  and could not be moved, split or merged - uniting a queenless colony
  is the textbook merge. Only terminal statuses lock a colony now; merging
  a colony into itself and dissolving twice are rejected.
- Moving a queen to another colony failed on the unique currentQueenId
  because the old colony kept pointing at her. The old colony now releases
  her (and becomes QUEENLESS); a queenless colony receiving a queen becomes
  ACTIVE; dissolved colonies cannot receive a queen.
- Completing a task twice moved completedAt and re-sent the webhook;
  reopening a task kept completedAt. Recurring templates created tasks
  without a due date and caught up missed weeks one stale task at a time.
- Automation rules created a new task and warning on every trigger (every
  stock removal below minimum). Tasks now record their source trigger and
  at most one open task per rule and object exists. The varroa threshold
  (mites per day) is only compared with natural-mite-fall rates, not with
  sample-based counts in another unit.
- New opt-in Idempotency-Key support for record-creating endpoints, so
  the offline queue can retry after a lost response without duplicates.
- Permission catalog sync crashed replicas booting concurrently on a
  fresh database (unique violation); it now uses createMany/skipDuplicates.
- Server-side validation for inspection rating scales (1-5), unique
  colony/harvest lists and net weight <= gross weight.
- Stale e2e expectations updated (permission count, trigger list, real PNG
  fixture for the file-signature check).

Migration is additive only (nullable Task column, new table).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 05:27:45 +02:00

193 lines
6.3 KiB
TypeScript

import { INestApplication } from '@nestjs/common';
import * as bcrypt from 'bcryptjs';
import * as fs from 'node:fs/promises';
import request from 'supertest';
import { App } from 'supertest/types';
import { PrismaService } from '../src/prisma/prisma.service';
import { createTestApp } from './utils/create-test-app';
import { login } from './utils/api';
// The upload checks the file's magic bytes against its declared type, so
// the fixture must start with a real PNG signature.
const PNG_BYTES = Buffer.concat([
Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a]),
Buffer.from('test image payload'),
]);
interface DocumentBody {
id: string;
entityType: string;
entityId: string;
fileName: string;
mimeType: string;
sizeBytes: number;
storagePath?: string;
}
describe('Documents (e2e)', () => {
let app: INestApplication<App>;
let prisma: PrismaService;
const beekeeperEmail = `documents-e2e-beekeeper-${Date.now()}@example.com`;
const readonlyEmail = `documents-e2e-readonly-${Date.now()}@example.com`;
const password = 'SuperSecret123!';
let beekeeperId: string;
let readonlyId: string;
let beekeeperToken: string;
let readonlyToken: string;
let apiaryId: string;
let colonyId: string;
let documentId: string;
beforeAll(async () => {
app = await createTestApp();
prisma = app.get(PrismaService);
const passwordHash = await bcrypt.hash(password, 12);
const beekeeper = await prisma.user.create({
data: {
email: beekeeperEmail,
passwordHash,
name: 'Documents E2E Beekeeper',
role: { connect: { key: 'BEEKEEPER' } },
},
});
beekeeperId = beekeeper.id;
const readonly = await prisma.user.create({
data: {
email: readonlyEmail,
passwordHash,
name: 'Documents E2E Readonly',
role: { connect: { key: 'READONLY' } },
},
});
readonlyId = readonly.id;
beekeeperToken = (await login(app, beekeeperEmail, password)).accessToken;
readonlyToken = (await login(app, readonlyEmail, password)).accessToken;
const apiary = await prisma.apiary.create({
data: { name: `Dokumente-Stand ${Date.now()}` },
});
apiaryId = apiary.id;
const colony = await prisma.colony.create({
data: {
code: `V-DOC-${Date.now()}`,
apiaryId,
colonyType: 'PRODUCTION_COLONY',
},
});
colonyId = colony.id;
});
afterAll(async () => {
await prisma.document.deleteMany({
where: { entityType: 'COLONY', entityId: colonyId },
});
await prisma.colony.deleteMany({ where: { id: colonyId } });
await prisma.apiary.deleteMany({ where: { id: apiaryId } });
await prisma.refreshToken.deleteMany({
where: { userId: { in: [beekeeperId, readonlyId] } },
});
await prisma.auditLog.deleteMany({
where: { userId: { in: [beekeeperId, readonlyId] } },
});
await prisma.user.deleteMany({
where: { id: { in: [beekeeperId, readonlyId] } },
});
await fs.rm('./test-uploads', { recursive: true, force: true });
await app.close();
});
it('rejects an upload from a role without write access', () => {
return request(app.getHttpServer())
.post('/api/v1/documents')
.set('Authorization', `Bearer ${readonlyToken}`)
.field('entityType', 'COLONY')
.field('entityId', colonyId)
.attach('file', PNG_BYTES, {
filename: 'bild.png',
contentType: 'image/png',
})
.expect(403);
});
it('rejects an unsupported mime type', () => {
return request(app.getHttpServer())
.post('/api/v1/documents')
.set('Authorization', `Bearer ${beekeeperToken}`)
.field('entityType', 'COLONY')
.field('entityId', colonyId)
.attach('file', Buffer.from('not an image'), {
filename: 'script.exe',
contentType: 'application/octet-stream',
})
.expect(400);
});
it('rejects an upload for a non-existent entity', () => {
return request(app.getHttpServer())
.post('/api/v1/documents')
.set('Authorization', `Bearer ${beekeeperToken}`)
.field('entityType', 'COLONY')
.field('entityId', 'does-not-exist')
.attach('file', PNG_BYTES, {
filename: 'bild.png',
contentType: 'image/png',
})
.expect(404);
});
it('lets a beekeeper upload a document and omits storagePath from the response', async () => {
const response = await request(app.getHttpServer())
.post('/api/v1/documents')
.set('Authorization', `Bearer ${beekeeperToken}`)
.field('entityType', 'COLONY')
.field('entityId', colonyId)
.attach('file', PNG_BYTES, {
filename: 'bild.png',
contentType: 'image/png',
})
.expect(201);
const body = response.body as DocumentBody;
documentId = body.id;
expect(body.entityType).toBe('COLONY');
expect(body.entityId).toBe(colonyId);
expect(body.fileName).toBe('bild.png');
expect(body.mimeType).toBe('image/png');
expect(body.storagePath).toBeUndefined();
});
it('lists documents for the entity', async () => {
const response = await request(app.getHttpServer())
.get(`/api/v1/documents?entityType=COLONY&entityId=${colonyId}`)
.set('Authorization', `Bearer ${readonlyToken}`)
.expect(200);
const body = response.body as DocumentBody[];
expect(body.some((entry) => entry.id === documentId)).toBe(true);
});
it('downloads the uploaded file with matching content and headers', async () => {
const response = await request(app.getHttpServer())
.get(`/api/v1/documents/${documentId}/download`)
.set('Authorization', `Bearer ${readonlyToken}`)
.expect(200);
expect(response.headers['content-type']).toContain('image/png');
expect(response.headers['content-disposition']).toContain('bild.png');
const downloaded = response.body as Buffer;
expect(Buffer.compare(downloaded, PNG_BYTES)).toBe(0);
});
it('rejects a delete from a role without write access', () => {
return request(app.getHttpServer())
.delete(`/api/v1/documents/${documentId}`)
.set('Authorization', `Bearer ${readonlyToken}`)
.expect(403);
});
it('lets a beekeeper delete the document', () => {
return request(app.getHttpServer())
.delete(`/api/v1/documents/${documentId}`)
.set('Authorization', `Bearer ${beekeeperToken}`)
.expect(204);
});
});