From 2458927d38b2a04b94bb6268f898af1362182436 Mon Sep 17 00:00:00 2001 From: Nick Szaunig Date: Sun, 23 Aug 2026 06:58:13 +0200 Subject: [PATCH] fix(backend): DELETE /webhooks/:id returns 204 No Content Matches REST convention and the frontend api-client's existing 204 fast-path, avoiding a JSON-parse crash on an empty response body. --- ApiCore-Backend/src/webhooks/webhooks.controller.ts | 11 ++++++++++- ApiCore-Backend/test/webhooks.e2e-spec.ts | 2 +- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/ApiCore-Backend/src/webhooks/webhooks.controller.ts b/ApiCore-Backend/src/webhooks/webhooks.controller.ts index dc57e87..eda8173 100644 --- a/ApiCore-Backend/src/webhooks/webhooks.controller.ts +++ b/ApiCore-Backend/src/webhooks/webhooks.controller.ts @@ -1,4 +1,12 @@ -import { Body, Controller, Delete, Get, Param, Post } from '@nestjs/common'; +import { + Body, + Controller, + Delete, + Get, + HttpCode, + Param, + Post, +} from '@nestjs/common'; import { ApiBearerAuth, ApiTags } from '@nestjs/swagger'; import { Role } from '../../generated/prisma'; import { Roles } from '../auth/decorators/roles.decorator'; @@ -28,6 +36,7 @@ export class WebhooksController { } @Delete(':id') + @HttpCode(204) delete(@Param('id') id: string, @CurrentUser() actor: AuthenticatedUser) { return this.webhooksService.delete(id, actor.id); } diff --git a/ApiCore-Backend/test/webhooks.e2e-spec.ts b/ApiCore-Backend/test/webhooks.e2e-spec.ts index 12c9ca5..6785abe 100644 --- a/ApiCore-Backend/test/webhooks.e2e-spec.ts +++ b/ApiCore-Backend/test/webhooks.e2e-spec.ts @@ -170,6 +170,6 @@ describe('Webhooks (e2e)', () => { return request(app.getHttpServer()) .delete(`/api/v1/webhooks/${subscriptionId}`) .set('Authorization', `Bearer ${adminAccessToken}`) - .expect(200); + .expect(204); }); });