fix: Paket 0 – data integrity, security hardening and field usability
Backend - Backup covers every Prisma model (bundle v3); a guard test fails for any new model that is neither backed up nor explicitly excluded. Unsealed bundles may only add rows to 27 legacy master/field tables and never overwrite; counters, ledgers, settings, roles etc. need a sealed file. Shared import limit BACKUP_MAX_IMPORT_BYTES (default 50 MB, max 256 MB) with warnings in log and UI; replaced document files are removed after commit. - Post-commit side effects (automation, calendar sync, webhooks) run via runAfterCommit and never turn a committed write into a 500, so retries with the same Idempotency-Key no longer create duplicates. - Calendar outbox is multi-replica safe: per-entry claims with stale takeover, revision-based settle, new Graph event only on 404/410, transactionId on create, 30 s Graph timeout, URL-encoded ids, GUID validation for groupId, "run now" in background and resets FAILED. - Automation tasks are deduplicated under a row lock on the rule. - Update DTOs follow one null rule: omitted = unchanged, null clears a nullable field, null on a required field is a 400. - Varroa mites/day is recomputed on correction; withdrawal status is checked against the harvest date (?at=), bounded colonyIds; inspection create is audited; updates re-enqueue calendar entries. - Dashboard, statistics and apiary/colony guards treat WEAK, CONSPICUOUS and QUEENLESS colonies as living. - Prisma errors and body-parser errors are logged without query values or request bodies. - Migration 20261012100000_calendar_sync_claims; schema index name aligned with the existing database object. Frontend - Sticky save bar sticks again (no scroll container ancestors, card uses overflow-clip), safe-area insets, scroll-padding, FAB hidden on forms, sticky desktop sidebar. - Inspections record yes / no / not checked instead of silent defaults. - All living colonies are selectable; shared RecordSelect, EnumSelect, ChoiceGroup and TriStateField replace per-page copies; selects show names instead of ids; labels point at real controls. - Emptied optional fields are sent as null (emptyToNull) so every field can be cleared; dates default to the local day and are sent via toApiDate. - Harvest withdrawal warning uses the harvest date; backup page warns when a backup outgrows the import limit and lists skipped tables. Build and docs - Docker builds fail unless lint, typecheck and unit tests pass. - ARCHITECTURE.md updated (assumptions 9-12, 19-21, section 8) and spec docs/superpowers/specs/2026-10-12-plattform-rueckgrat-und-fahrplan-design.md for the backbone (api/worker/job roles, domain event outbox) and the feature roadmap T3-T7. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This commit is contained in:
1 parent
f5b1964223
commit
10cbe9bf2d
310 files changed
+12177
-3746
No files matched your search
@@ -8,6 +8,7 @@ import {
|
||||
IsString,
|
||||
} from 'class-validator';
|
||||
import { SwarmControlAction, SwarmMood } from '../../../generated/prisma';
|
||||
import { IsOptionalNotNull } from '../../common/validation/is-optional-not-null';
|
||||
|
||||
export class CreateSwarmControlCheckDto {
|
||||
@ApiProperty()
|
||||
@@ -24,17 +25,17 @@ export class CreateSwarmControlCheckDto {
|
||||
queenCellsFound?: number;
|
||||
|
||||
@ApiPropertyOptional()
|
||||
@IsOptional()
|
||||
@IsOptionalNotNull()
|
||||
@IsBoolean()
|
||||
queenCellsCapped?: boolean;
|
||||
|
||||
@ApiPropertyOptional({ enum: SwarmMood })
|
||||
@IsOptional()
|
||||
@IsOptionalNotNull()
|
||||
@IsEnum(SwarmMood)
|
||||
swarmMood?: SwarmMood;
|
||||
|
||||
@ApiPropertyOptional({ enum: SwarmControlAction })
|
||||
@IsOptional()
|
||||
@IsOptionalNotNull()
|
||||
@IsEnum(SwarmControlAction)
|
||||
actionTaken?: SwarmControlAction;
|
||||
|
||||
|
||||
@@ -8,4 +8,5 @@ import { CreateSwarmControlCheckDto } from './create-swarm-control-check.dto';
|
||||
*/
|
||||
export class UpdateSwarmControlCheckDto extends PartialType(
|
||||
CreateSwarmControlCheckDto,
|
||||
{ skipNullProperties: false },
|
||||
) {}
|
||||
@@ -102,6 +102,24 @@ describe('SwarmControlService', () => {
|
||||
);
|
||||
});
|
||||
|
||||
it('update clears the next check date on null', async () => {
|
||||
prisma.swarmControlCheck.findUnique.mockResolvedValue({
|
||||
...check,
|
||||
nextCheckDate: new Date('2026-05-08T00:00:00.000Z'),
|
||||
});
|
||||
prisma.swarmControlCheck.update.mockResolvedValue(check);
|
||||
|
||||
await service.update('check-1', { nextCheckDate: null as never }, 'user-1');
|
||||
|
||||
const [[updateArg]] = prisma.swarmControlCheck.update.mock.calls as [
|
||||
[{ data: { nextCheckDate?: Date | null } }],
|
||||
];
|
||||
expect(updateArg.data.nextCheckDate).toBeNull();
|
||||
expect(auditLog.record).toHaveBeenCalledWith(
|
||||
expect.objectContaining({ action: 'UPDATE', entityId: 'check-1' }),
|
||||
);
|
||||
});
|
||||
|
||||
it('findByColony orders results chronologically', async () => {
|
||||
prisma.swarmControlCheck.findMany.mockResolvedValue([check]);
|
||||
|
||||
|
||||
@@ -3,6 +3,7 @@ import { PrismaService } from '../prisma/prisma.service';
|
||||
import { AuditLogService } from '../audit/audit-log.service';
|
||||
import { AutomationService } from '../automation/automation.service';
|
||||
import { SwarmControlCheck } from '../../generated/prisma';
|
||||
import { optionalDate } from '../common/patch-values';
|
||||
import { CreateSwarmControlCheckDto } from './dto/create-swarm-control-check.dto';
|
||||
import { UpdateSwarmControlCheckDto } from './dto/update-swarm-control-check.dto';
|
||||
|
||||
@@ -45,9 +46,7 @@ export class SwarmControlService {
|
||||
data: {
|
||||
...dto,
|
||||
date: new Date(dto.date),
|
||||
nextCheckDate: dto.nextCheckDate
|
||||
? new Date(dto.nextCheckDate)
|
||||
: undefined,
|
||||
nextCheckDate: optionalDate(dto.nextCheckDate),
|
||||
userId: actingUserId,
|
||||
},
|
||||
});
|
||||
@@ -73,9 +72,7 @@ export class SwarmControlService {
|
||||
data: {
|
||||
...dto,
|
||||
date: dto.date ? new Date(dto.date) : undefined,
|
||||
nextCheckDate: dto.nextCheckDate
|
||||
? new Date(dto.nextCheckDate)
|
||||
: undefined,
|
||||
nextCheckDate: optionalDate(dto.nextCheckDate),
|
||||
},
|
||||
});
|
||||
await this.auditLog.record({
|
||||
|
||||
Reference in new issue
Block a user