feat: RBAC Phase 2e - Verwaltung auf @RequirePermission umgestellt, Coverage-Test aktiviert
Users, Webhooks, Automation, Import, AuditLog: die klassenweiten @Roles(Role.ADMIN)-Blankets (die gefaehrlichsten der Migration, da sie JEDE Route der Klasse abdecken) durch pro-Route @RequirePermission ersetzt. Effektiver Zugriff unveraendert: ADMIN besitzt weiterhin alle betroffenen Permission-Keys, jede andere Rolle bleibt ausgeschlossen. Damit ist kein @Roles(...) mehr in der Codebase in Benutzung - alle 23 Controller laufen jetzt vollstaendig ueber @RequirePermission. test/authorization-coverage.e2e-spec.ts (bisher it.skip mit TODO fuer "nach Phase 2") ist jetzt scharf geschaltet und bestaetigt: 0 Routen ohne Rechte-Pruefung, 0 ungueltige Permission-Keys. Verifiziert: tsc, lint, build, unit (222/222), volle e2e-Suite 159/159 gruen - keine uebersprungenen Tests mehr. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This commit is contained in:
1 parent
8832081973
commit
0284077d3b
6 files changed
+19
-21
No files matched your search
@@ -1,7 +1,6 @@
|
||||
import { Body, Controller, Get, Param, Patch, Post } from '@nestjs/common';
|
||||
import { ApiBearerAuth, ApiTags } from '@nestjs/swagger';
|
||||
import { LegacyRole as Role } from '../../generated/prisma';
|
||||
import { Roles } from '../auth/decorators/roles.decorator';
|
||||
import { RequirePermission } from '../auth/decorators/require-permission.decorator';
|
||||
import { CurrentUser } from '../auth/decorators/current-user.decorator';
|
||||
import type { AuthenticatedUser } from '../auth/types/authenticated-user';
|
||||
import { CreateUserDto } from './dto/create-user.dto';
|
||||
@@ -11,25 +10,28 @@ import { UsersService } from './users.service';
|
||||
@ApiTags('users')
|
||||
@ApiBearerAuth()
|
||||
@Controller('users')
|
||||
@Roles(Role.ADMIN)
|
||||
export class UsersController {
|
||||
constructor(private readonly usersService: UsersService) {}
|
||||
|
||||
@RequirePermission('users:read')
|
||||
@Get()
|
||||
findAll() {
|
||||
return this.usersService.findAll();
|
||||
}
|
||||
|
||||
@RequirePermission('users:create')
|
||||
@Post()
|
||||
create(@Body() dto: CreateUserDto, @CurrentUser() actor: AuthenticatedUser) {
|
||||
return this.usersService.create(dto, actor.id);
|
||||
}
|
||||
|
||||
@RequirePermission('users:read')
|
||||
@Get(':id')
|
||||
findOne(@Param('id') id: string) {
|
||||
return this.usersService.findSummaryById(id);
|
||||
}
|
||||
|
||||
@RequirePermission('users:update')
|
||||
@Patch(':id')
|
||||
update(
|
||||
@Param('id') id: string,
|
||||
@@ -39,11 +41,13 @@ export class UsersController {
|
||||
return this.usersService.update(id, dto, actor.id);
|
||||
}
|
||||
|
||||
@RequirePermission('users:deactivate')
|
||||
@Post(':id/deactivate')
|
||||
deactivate(@Param('id') id: string, @CurrentUser() actor: AuthenticatedUser) {
|
||||
return this.usersService.deactivate(id, actor.id);
|
||||
}
|
||||
|
||||
@RequirePermission('users:deactivate')
|
||||
@Post(':id/activate')
|
||||
activate(@Param('id') id: string, @CurrentUser() actor: AuthenticatedUser) {
|
||||
return this.usersService.activate(id, actor.id);
|
||||
|
||||
Reference in new issue
Block a user